Closed
Bug 360639
Opened 18 years ago
Closed 18 years ago
Folders for offline use dialog lets you pick saved search folders
Categories
(Thunderbird :: Mail Window Front End, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird2.0
People
(Reporter: mscott, Assigned: mscott)
Details
(Keywords: fixed1.8.1.1, verified1.8.1.3, Whiteboard: fixed-thunderbird2)
Attachments
(1 file, 1 obsolete file)
755 bytes,
patch
|
Bienvenu
:
review+
mscott
:
superreview+
mscott
:
approval-thunderbird2+
|
Details | Diff | Splinter Review |
And if you pick a saved search folder for offline use, and then download messages for offline use, we issue an illegal select command on the non existent saved search folder.
Assignee | ||
Updated•18 years ago
|
Flags: blocking-thunderbird2+
Updated•18 years ago
|
OS: Windows XP → All
Hardware: PC → All
Assignee | ||
Comment 1•18 years ago
|
||
This keeps virtual folders out of the select folders for offline use. But Neil's template builder foo is better than mine so I'll ask him for a review to make sure this looks ok.
Attachment #247617 -
Flags: review?(neil)
Comment 2•18 years ago
|
||
Attachment #247823 -
Flags: superreview?(mscott)
Assignee | ||
Comment 3•18 years ago
|
||
Comment on attachment 247823 [details] [diff] [review] Alternative approach I like this approach more because virtual folders don't support offline so lets return an accurate value for GetSupportsOffline.
Attachment #247823 -
Flags: superreview?(mscott)
Attachment #247823 -
Flags: superreview+
Attachment #247823 -
Flags: review?(bienvenu)
Attachment #247823 -
Flags: approval-thunderbird2+
Comment 4•18 years ago
|
||
Comment on attachment 247823 [details] [diff] [review] Alternative approach me too, Thx, Neil
Attachment #247823 -
Flags: review?(bienvenu) → review+
Comment 5•18 years ago
|
||
Comment on attachment 247617 [details] [diff] [review] filter out virtual folders I take it this patch is obsolete ;-)
Attachment #247617 -
Attachment is obsolete: true
Attachment #247617 -
Flags: review?(neil)
Comment 6•18 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: fixed-thunderbird2
Comment 8•17 years ago
|
||
verified fixed 1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 ID:2007032620
Keywords: verified1.8.1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•