Closed
Bug 360727
Opened 18 years ago
Closed 18 years ago
leak stats sometimes show up in wrong build
Categories
(Webtools Graveyard :: Tinderbox, defect)
Webtools Graveyard
Tinderbox
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: cls)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
949 bytes,
patch
|
bear
:
review+
|
Details | Diff | Splinter Review |
This is the second time I've seen this since the tinderbox upgrade, and I'd never seen it before, so I think it's a regression. Sometimes the leak stats for a build are showing up on the wrong build -- in addition to the correct one. At least the occurrence I just noticed: http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla1.8&hours=1&maxdate=1163541600&legend=0 is a case where both the start and end times match. The numbers for balsa-18branch are incorrectly showing up in the prometheus-vm column. Steps to reproduce: load http://tinderbox.mozilla.org/showbuilds.cgi?tree=Mozilla1.8&hours=1&maxdate=1163541600&legend=0 Expected results: no leak stats in prometheus-vm column Actual results: The build in prometheus-vm's column from 13:44 to 13:53 has leak stats -- perhaps those from the balsa-18branch build with the same times.
Updated•18 years ago
|
QA Contact: timeless → tinderbox
processbuild.pl was using $builddate.$$.gz as a uniquely named logfile. This was fine when processbuild.pl was being run once for each mail that came in. Now that processbuild.pl is only run once for a batch of mail, $$ is no longer unique so builds with the same start time clobber each other. When the mail is stored for processing, it is given a unique string based upon the current time and the current pid. We can use that unique string in the logfile name. So the new name of logfiles is $start_time.$mail_time.$$ .
Updated•18 years ago
|
Attachment #251126 -
Flags: review?(bear) → review+
Checking in webtools/tinderbox/processbuild.pl; /cvsroot/mozilla/webtools/tinderbox/processbuild.pl,v <-- processbuild.pl new revision: 1.67; previous revision: 1.66 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 3•18 years ago
|
||
Now that it's too late... :) How about using File::Temp to create a guaranteed-unique filename?
Updated•10 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•