360792 - mail.delete_matches_sort_order does not work when using imap mark as deleted model

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

Follow up to bug 349763.

The pref "mail.delete_matches_sort_order" does not work when using the imap mark-as-deleted model. I don't see a reason it shouldn't.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Enables the pref for imap mark as deleted model.

Comment 2

[David :Bienvenu]

Comment on attachment 245771 [details] [diff] [review]
proposed fix

Scott's on vacation - taking review. This looks good to me.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

mozilla/mailnews/base/src/nsMsgDBView.cpp 	1.257

Comment 4

[Scott MacGregor]

How's this been looking on the trunk? I haven't heard of any regressions, but at the same time I don't know how much trunk test coverage we get with users using the imap mark as deleted model. 

Comment 5

[Magnus Melin [:mkmelin]]

I can only speak for myself. I have had the pref set to true and haven't had any problems with it.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/mailnews/base/src/nsMsgDBView.cpp 	1.222.4.29

Comment 7

[wkearney99]

Is there any way to disable movement at all?  Let's say you're not using the trashcan or hiding deleted messages.  You're just using deleting them in place on the IMAP server, to be purged later.  It would be nice to have the option to simply stay on the deleted message and not move at all, regardless of sort order.   If the message wasn't being left visible I can certainly understand what moving is necessary. 

Personally I find it distracting to have the message cursor moving around.  I prefer to use the arrow keys to do it myself.

So this isn't a bug, but a feature request.  Where's the right place to raise it?

Comment 8

[Magnus Melin [:mkmelin]]

In a new bug, with severity enh.

Comment 9

[wkearney99]

Thank you Magnus, I raised it here: https://bugzilla.mozilla.org/show_bug.cgi?id=396458