Last Comment Bug 360809 - Default Client options disabled after making TB the default mail or news client (system integration dialog)
: Default Client options disabled after making TB the default mail or news clie...
Product: Thunderbird
Classification: Client Software
Component: OS Integration (show other bugs)
: Trunk
: All All
-- normal with 1 vote (vote)
: Thunderbird 19.0
Assigned To: :aceman
: 567579 (view as bug list)
Depends on:
  Show dependency treegraph
Reported: 2006-11-15 10:45 PST by Magnus Melin
Modified: 2012-11-19 11:52 PST (History)
11 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

screenshot after making default news client (12.97 KB, image/png)
2006-11-15 10:48 PST, Magnus Melin
no flags Details
ui patch to skip the disabling (3.52 KB, patch)
2008-06-12 03:50 PDT, Magnus Melin
no flags Details | Diff | Splinter Review
screenshot of "locked-on" mac thunderbird default email (50.55 KB, image/tiff)
2010-10-20 14:55 PDT, deb.zilky
no flags Details
patch (4.40 KB, patch)
2012-10-21 14:26 PDT, :aceman
bwinton: ui‑review+
Details | Diff | Splinter Review
patch v2 (4.34 KB, patch)
2012-10-29 12:38 PDT, :aceman
mconley: review+
Details | Diff | Splinter Review
patch v3 (4.59 KB, patch)
2012-11-19 11:34 PST, :aceman
acelists: review+
Details | Diff | Splinter Review

Description User image Magnus Melin 2006-11-15 10:45:48 PST
Use the Preferences General > "Check now" button to bring up the Default Client dialog. Check E-mail and Newsgroups and hit OK.

Now (or later after restart) come back and click "Check now" again. The E-mail and Newsgroups options are now grayed out for some reason. (If you have it set to check for default on startup the options are also disabled.)

So if you ever check it you are unable to unset thunderbird as default.
Comment 1 User image Magnus Melin 2006-11-15 10:48:12 PST
Created attachment 245674 [details]
screenshot after making default news client

BTW, This is Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1) Gecko/20061115 Thunderbird/2.0b1pre ID:2006111503 and also todays trunk btw.
Comment 2 User image Phil Ringnalda (:philor) 2008-02-05 21:45:19 PST
It took me an embarrassingly long time to realize that this is a UI issue (since I'm pretty sure we don't want to be the only email client on any platform that anyone's ever seen that implements "give your system no default email client" and implementing UI to set another client as default would only be proper platform behavior on OS X, where the UI to choose defaults for browser and mail are in Safari's and's prefs, not in an OS control panel), and that embarrassingly long time makes me think it's a real UI issue. 

If we just had labels saying "Thunderbird is set as your default email client" and "Thunderbird is set as your default news client" then I'd probably realize right off that to change that, I need to either open some other program and set it as default, or use "Preferred Applications" or "Set Program Access and Defaults", but having a disabled checkbox just screams "you could uncheck me, if only you could figure out why I'm disabled, you dummy."
Comment 3 User image Magnus Melin 2008-06-12 03:50:45 PDT
Created attachment 324760 [details] [diff] [review]
ui patch to skip the disabling

Unfortunately, there seems to be no (toolkit) way to unset as default client :(
Comment 4 User image Chas Belov 2010-09-12 14:14:23 PDT
I too was tripped up by this, only as of 3.1.3 this includes RSS feeds as well.  Mac OS X.
Comment 5 User image deb.zilky 2010-10-20 05:44:52 PDT
Comment on attachment 324760 [details] [diff] [review]
ui patch to skip the disabling

HELP!!!!! I just want to stop thunderbird being my default email reader - what do I do with this patch
Comment 6 User image Ludovic Hirlimann [:Usul] 2010-10-20 05:47:39 PDT
Comment on attachment 324760 [details] [diff] [review]
ui patch to skip the disabling

sorry for the noise
Comment 7 User image deb.zilky 2010-10-20 14:55:08 PDT
Created attachment 484833 [details]
screenshot of "locked-on" mac thunderbird default email
Comment 8 User image Wayne Mery (:wsmwk, NI for questions) 2011-12-12 05:48:10 PST
Magnus, are you interested in finishing this off?
Comment 9 User image Magnus Melin 2011-12-12 05:59:12 PST
No, i don't think so.
Comment 10 User image :aceman 2012-09-26 13:09:30 PDT
I encountered this too while working on bug 476426. As already mentioned, there is currently no way to unset TB as the default client. The shell-service has no such method. So the disabling is intentional to show the user he can't remove it. The existing UI patch here is useless without the backend part.

It is probably needed to run other client and make that one the default from inside it. Or use the Windows built-in controls.
Comment 11 User image :aceman 2012-09-27 01:47:48 PDT
*** Bug 567579 has been marked as a duplicate of this bug. ***
Comment 12 User image :aceman 2012-09-27 02:04:29 PDT
From reading other bugs and comments it looks like coding the "unset itself as default client" method (for shell service) is quite hard (at least on Windows). So we can't expect it to be done soon.

Bwinton, what about showing an info bar in the dialog to inform the user about that. Like this:
"If you want to set a different application as the default client, start that application and use 'Set default' action from inside it."
Comment 13 User image Blake Winton (:bwinton) (:☕️) 2012-09-27 08:20:02 PDT
I'm not a fan of the info bar.  (In general, people don't read stuff. ;)

Perhaps we could change the list of checkboxes to a list of buttons?  "Set as default mail client", "Set as default news client", and then if it's already set, have text in the same place saying "Thunderbird is your default rss client."?
Comment 14 User image :aceman 2012-09-27 08:29:42 PDT
Yeah, but then if the unsetting gets implemented we'd need to redo the dialog again, maybe back to what it is now ;)

What about a tooltip showing when hovering over a disabled item?

Yes, the dialog is also used as a way to check the defaults so we need to preserve that functionality. It must not be a one way button to set the defaults. So what you propose is OK. The buttons just won't be so nice visually :)
Comment 15 User image :aceman 2012-09-27 08:34:26 PDT
If we rework the dialog in such dramatic way, then the buttons in bug 476426 will get a different meaning again :)
Comment 16 User image Blake Winton (:bwinton) (:☕️) 2012-09-27 09:23:29 PDT
Does any other email client have an "un-set me" option?  (And if so, what does it do in that case?)
Comment 17 User image :aceman 2012-09-27 10:27:34 PDT
No, I don't know any. Maybe it is not possible?
Comment 18 User image Blake Winton (:bwinton) (:☕️) 2012-10-01 11:26:30 PDT
Sure, let's see what the tooltip looks like.

Comment 19 User image :aceman 2012-10-21 14:26:38 PDT
Created attachment 673731 [details] [diff] [review]

The tooltip will appear only on items that are disabled.
Comment 20 User image Blake Winton (:bwinton) (:☕️) 2012-10-29 07:56:49 PDT
Comment on attachment 673731 [details] [diff] [review]

>+++ b/mail/locales/en-US/chrome/messenger/systemIntegrationDialog.dtd
>@@ -6,13 +6,15 @@
>+<!ENTITY unsetDefault.tooltip "It is not possible to unset &brandShortName; as the default client from this dialog. To set another application as the default client you must start that application and use its 'Set as default' dialog, or use the Operating system built-in tool.">

Okay, the tooltip doesn't seem horrible, but the text is longer than I think is reasonable for a tooltip, so I'll say ui-r=me, with shorter text.  How about something along the lines of:
It is not possible to unset &brandShortName; as the default client within &brandShortName;. To make another application the default you must use its 'Set as default' dialog.

(That new text brings the tooltip down to two lines, which seems much better to me. ;)

Comment 21 User image :aceman 2012-10-29 12:38:40 PDT
Created attachment 676267 [details] [diff] [review]
patch v2
Comment 22 User image Mike Conley (:mconley) 2012-11-16 13:46:50 PST
Comment on attachment 676267 [details] [diff] [review]
patch v2

Review of attachment 676267 [details] [diff] [review]:

r=me with nit fixed. Thanks aceman!

::: mail/base/content/systemIntegrationDialog.js
@@ +48,2 @@
>      }
> +    if (!this._mailCheckbox.disabled)

Nit - I generally like a newline after a block.
Comment 23 User image :aceman 2012-11-19 11:34:52 PST
Created attachment 683244 [details] [diff] [review]
patch v3

Comment 24 User image Mike Conley (:mconley) 2012-11-19 11:52:48 PST

Note You need to log in before you can comment on or make changes to this bug.