36085 - Radio buttons with the same name visible across forms

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Daniel van der Zee]

A page with two forms where both forms have a series of radio buttons with the 
same name "leaks" the names to the other form.

See attached testcase for an example. It should pop-up "2" but says "4" instead"

Comment 1

[Daniel van der Zee]

Attachment: Test case

Comment 2

[Daniel van der Zee]

The problem appears to be in the implementation of 
nsFormControlList::GetNamedObject in 
/layout/html/content/src/nsHTMLFormElement.cpp.

Where the following lines:

    // If it is, then get all radio buttons or checkboxes with the same name
    if (document && (type.EqualsWithConversion("Radio") || 
type.EqualsWithConversion("Checkbox"))) {
      nsCOMPtr<nsIDOMHTMLDocument> htmlDoc = do_QueryInterface(document);
      if (htmlDoc) {
        nsCOMPtr<nsIDOMNodeList> list;
        result = htmlDoc->GetElementsByName(name, getter_AddRefs(list));

Queries the document for items with the same name, instead of the form.

Comment 3

[Daniel van der Zee]

By removing the check for type="radio" or type="check" above, bug 34858 will be 
fixed too.

Comment 4

[Johnny Stenback (:jst)]

This was fixed when the fix for bug 40571 was checked in, marking fixed.

Comment 5

[Prashant Desale]

Verified with 2000-07-07-10.