360878 - "De-zooming" continually expands window rather than returning to previous size on some pages

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

STR: 

1. Visit http://hidenosuke.org/
2. Zoom (page expands by about 1/4"
3. Zoom again

Expected: Window shrinks by ca. 1/4" back to original size

Actual: Window continues to expand by about 1/4" with each press of "zoom"

Switching tabs between steps 2 and 3 causes us to properly de-zoom.  Not sure how common sites with this issue will be.  Targeting to 1.1 for now.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

about:mozilla, about:about, and about:cache illustrate this, too.

Comment 2

[philippe (part-time)]

On my trunk build/10.4.8, nothing happens for those pages.
My window size is about 1100px by 700px, zoom does not expand nor shrink the window, which is what I would expect.

(and that is much better than Safari, which shrinks the window, and sends it in the bottom left corner of the screen).

Comment 3

[Torben]

All of these work for me too, both on branch and trunk (latest nightlies). Smokey, what is your window and screen size?

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

My window is 906x874 (somewhere around 900px wide at any given time, given bug 350331), and my screen is 1400x900 (the other vertical pixels are all the menubar).

Comment 5

[Ben Willmore]

I see the same behaviour as Smokey (on a Macbook screen).

Comment 6

[Torben]

I found a way to reproduce this, the problem is that we add space for a vertical scrollbar (due the padding we do to guard against rounding errors) even though it will not be shown. Now I just have to figure out how to fix this...

Comment 7

[Torben]

Attachment: Only add padding when the window's height is lees than the screen's height

This moves the adding of 1 extra pixel to BWC and only adds it when the resulting height/width is less than the screen's.

Comment 8

[Håkan Waara]

Comment on attachment 247991 [details] [diff] [review]
Only add padding when the window's height is lees than the screen's height

I'm sorry, I won't have time for this...

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Since a2 will be the first time we ship with zoom, it'd be nice to get some of these zoom bugs fixed instead of shipping a partially busted impl.  


(The patch works nicely in the cases I've tried, btw.  Pages like these that really shouldn't expand at all no longer do....)

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 247991 [details] [diff] [review]
Only add padding when the window's height is lees than the screen's height

Stuart, can you take a look at this?

Comment 11

[Stuart Morgan]

Comment on attachment 247991 [details] [diff] [review]
Only add padding when the window's height is lees than the screen's height

r=me

Comment 12

[Torben]

Comment on attachment 247991 [details] [diff] [review]
Only add padding when the window's height is lees than the screen's height

This is included in the patch in bug 361049.

Comment 13

[froodian (Ian Leue)]

Fixed by bug 361049.