360933 - Source code license cleanup

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Wan-Teh Chang]

The following assembly code files in NSPR still use the MPL/GPL
dual license.  Gervase, do you know why?

1. os2emx.s and os2vaclegacy.s in mozilla/nsprpub/pr/src/md/os2
need to use the triple license.

2. All the os_*.s files in mozilla/nsprpub/pr/src/md/unix need
to use the triple license.

The following files may contain code based on sample code from
a book, as the readme.1st file in these two directories point
out:

3. Remove all the files in mozilla/nsprpub/lib/tests/windows
from CVS.  They are dead code (for the plevent.h functions,
which have been moved to XPCOM).

Update mozilla/nsprpub/lib/tests/Makefile.in.

4. Remove all the files in mozilla/nsprpub/pr/tests/w16gui.
They are dead code (for the plevent.h functions and for Win16
support).

Update mozilla/nsprpub/pr/tests/README.TXT.

Comment 1

[Wan-Teh Chang]

Gervase, here is another piece of information.

All the NSPR source files that still use the dual license are
exactly the files with the .s file name suffix:

$ pwd
/home/wtchang/nspr-4.6-branch/mozilla/nsprpub
$ find . -name "*.s" -print
./pr/src/md/os2/os2emx.s
./pr/src/md/os2/os2vaclegacy.s
./pr/src/md/unix/os_AIX.s
./pr/src/md/unix/os_BSD_386_2.s
./pr/src/md/unix/os_Darwin_ppc.s
./pr/src/md/unix/os_Darwin_x86.s
./pr/src/md/unix/os_HPUX.s
./pr/src/md/unix/os_HPUX_ia64.s
./pr/src/md/unix/os_Irix.s
./pr/src/md/unix/os_Linux_ia64.s
./pr/src/md/unix/os_Linux_x86.s
./pr/src/md/unix/os_Linux_x86_64.s
./pr/src/md/unix/os_ReliantUNIX.s
./pr/src/md/unix/os_SunOS.s
./pr/src/md/unix/os_SunOS_sparcv9.s
./pr/src/md/unix/os_SunOS_ultrasparc.s
./pr/src/md/unix/os_SunOS_x86.s
./pr/src/md/unix/os_SunOS_x86_64.s

Comment 2

[Gervase Markham [:gerv]]

Yes, I know why :-)

Gerv

*** This bug has been marked as a duplicate of 344691 ***

Comment 3

[Wan-Teh Chang]

Thank you, Gerv.

Issues 3 and 4 of this bug are not related to .s files.
So I reopened this bug but made it depend on bug 344691.

Comment 4

[Gervase Markham [:gerv]]

OK. Wan-Teh, I assume you are happy to fix issues 3 and 4?

Gerv

Comment 5

[Wan-Teh Chang]

Gerv, I am happy to fix issues 3 and 4.  Is it sufficient to
only fix issues 3 and 4 on the Mozilla trunk?  Or do I also
need to fix them on the MOZILLA_1_8_BRANCH (for Firefox 2.0.0.x)?

Comment 6

[Gervase Markham [:gerv]]

Wan-Teh: sorry for not getting back to you earlier. I'm sure it's fine to fix it just on the trunk.

Gerv

Comment 7

[Wan-Teh Chang]

Gerv fixed issues 1 and 2 on the NSPR trunk (NSPR 4.7).

I fixed issues 3 and 4 on the NSPR trunk (NSPR 4.7).

These changes will appear on the Mozilla trunk (1.9 alpha 2)
next time I update the NSPRPUB_PRE_4_2_CLIENT_BRANCH.