Closed Bug 361058 Opened 14 years ago Closed 14 years ago
.95 .3 fails to compile ns List Box Body Frame .cpp
Bug 258513 broke compilation for gcc2.95.3 under BeOS, but maybe others as well. The lines: return mTopFrame->IsBoxFrame() ? mTopFrame : nsnull; needs to be changed to: return mTopFrame->IsBoxFrame() ? (nsIBox*) mTopFrame : nsnull; Or it will stop on ambigous candidates.
The same error also occurs with Sun's compiler: http://tinderbox.mozilla.org/SeaMonkey-Ports/ It's a regression from bug 360642.
Comment on attachment 245845 [details] [diff] [review] Suggested patch not doing reviews, sorry. please ask one of the module owners listed on http://www.mozilla.org/owners.html
hrm, buggy compilers... Does the patch fix both beos and sun?
Comment on attachment 245845 [details] [diff] [review] Suggested patch I'll check this in if you roc can r+sr
Comment on attachment 245845 [details] [diff] [review] Suggested patch Use NS_STATIC_CAST
Checked in. tgh, if you can now compile nsListBoxBodyFrame.cpp, please mark this FIXED.
Needed on branches if bug 360642 is taken
Assignee: nobody → Olli.Pettay
Comment on attachment 245845 [details] [diff] [review] Suggested patch approved for 1.8/1.8.0 branches, a=dveditz
I can't verify this completly because bug 313309 dropped support for gcc2.9. I think this bug is fixed though.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
v.fixed based on code inspection, reporter comments, and the fact that this has been fixed for a while without anyone screaming about it. :-) If anyone still has compilation issues, please let us know.
You need to log in before you can comment on or make changes to this bug.