361058 - gcc2.95.3 fails to compile nsListBoxBodyFrame.cpp

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[tqh]

Bug 258513 broke compilation for gcc2.95.3 under BeOS, but maybe others as well.

The lines:
      return mTopFrame->IsBoxFrame() ? mTopFrame : nsnull;
needs to be changed to:
      return mTopFrame->IsBoxFrame() ? (nsIBox*) mTopFrame : nsnull;

Or it will stop on ambigous candidates.

Comment 1

[tqh]

Attachment: Suggested patch

r?

Comment 2

[Mats Palmgren (inactive)]

The same error also occurs with Sun's compiler:
http://tinderbox.mozilla.org/SeaMonkey-Ports/

It's a regression from bug 360642.

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 245845 [details] [diff] [review]
Suggested patch

not doing reviews, sorry.  please ask one of the module owners listed on http://www.mozilla.org/owners.html

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

hrm, buggy compilers...
Does the patch fix both beos and sun?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 245845 [details] [diff] [review]
Suggested patch

I'll check this in if you roc can r+sr

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 245845 [details] [diff] [review]
Suggested patch

Use NS_STATIC_CAST

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Checked in.
tgh, if you can now compile nsListBoxBodyFrame.cpp, please mark this
FIXED.

Comment 8

[Daniel Veditz [:dveditz]]

Needed on branches if bug 360642 is taken

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 245845 [details] [diff] [review]
Suggested patch

approved for 1.8/1.8.0 branches, a=dveditz

Comment 10

[tqh]

I can't verify this completly because bug 313309 dropped support for gcc2.9. I think this bug is fixed though.

Comment 11

[Jay Patel [:jay]]

v.fixed based on code inspection, reporter comments, and the fact that this has been fixed for a while without anyone screaming about it. :-)  If anyone still has compilation issues, please let us know.