Closed
Bug 361140
Opened 18 years ago
Closed 18 years ago
Upgrades from versions with enums fail UTF-8 conversion
Categories
(Bugzilla :: Installation & Upgrading, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: mkanat, Assigned: mkanat)
Details
Attachments
(1 file)
1.28 KB,
patch
|
bugzilla-mozilla
:
review+
|
Details | Diff | Splinter Review |
The old enum fields need to be exempted from the UTF-8 table conversion: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'CHARACTER SET binary DEFAULT 'blocker' NOT NULL' at line 2 at Bugzilla/DB/Mysql.pm line 614 Bugzilla::DB::Mysql::bz_setup_database('Bugzilla::DB::Mysql=HASH(0xaec1978)') called at ./checksetup.pl line 162
Assignee | ||
Updated•18 years ago
|
Flags: blocking3.0+
Assignee | ||
Comment 1•18 years ago
|
||
Okay, I've fixed this here. I also noticed another tiny bug--the ALTER TABLE for the table's default charset was in the wrong place, so it was just being called too many times.
Assignee: installation → mkanat
Status: NEW → ASSIGNED
Attachment #245921 -
Flags: review?(bugzilla-mozilla)
Comment 2•18 years ago
|
||
Comment on attachment 245921 [details] [diff] [review] v1 >Index: Bugzilla/DB/Mysql.pm >+ # Our conversion code doesn't work on enum fields, but they >+ # all go away later in checksetup anyway. >+ next if $column->{Type} =~ /enum/i; Nit: I'd rather see /^enum/i;
Attachment #245921 -
Flags: review?(bugzilla-mozilla) → review+
Updated•18 years ago
|
Flags: approval?
Updated•18 years ago
|
Flags: approval? → approval+
Assignee | ||
Comment 3•18 years ago
|
||
Yeah, I wasn't certain that /^enum/ would always work, but I suppose it would. I didn't fix it, though. Checking in Bugzilla/DB/Mysql.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Mysql.pm,v <-- Mysql.pm new revision: 1.47; previous revision: 1.46 done
Assignee | ||
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•