36116 - multiple field data: for fullname, only one value seen

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect, P3)

Description

[sairuh (rarely reading bugmail)]

i've been seeing this in both m15 and m16 --i imagine it'd affect all platforms,
but due to bug 28466 i'll give steps here using the winNT build (today using
2000.04.17.06-m15).

1. go to the above URL and fill in both the firstname and lastname fields, eg,
"Jane" and "Dough."
2. select Tasks > Personal Managers > Form Manager > Capture Data from Form.
3. verify that the data has been captured by going to Tasks > Personal Managers
> Form Manager > View Stored Form Data. the resulting dialog should display
name.first and name.last with the corresponding values (once you select them
w/the mouse) from step 1.
4. dismiss the Stored Form Data dialog by clicking OK.
5. repeat steps 1-4, but enter a different first and lastname, eg, "Anna" and
"Madrigal." when you select the field name in the dialog, it'll list two values.
6. go to http://www.mozilla.org/wallet/samples/ and select a sample form *where
the name.first and name.last are to be put into a single form field, eg, a
fullname field. the sample form for amazon.com or ebay.com would work.
7. select Tasks > Personal Managers > Form Manager > Prefill Form Safely.

result: the confirmation dialog (see bug 36114 for its misleading label) lists a
field called Name, but its corresponding value (a droplist) contains only a
single value, "Jane Dough."

expected: the value droplist should contain all possible values.

note: this is *not* a problem when i select a form that has two fields for the
name (eg, cdnow.com form), one for the firstname and one for the lastname. the
confirmation dialog in fact lists Name.First (with a droplist containing Jane
and Anna) and Name.Last (w/a droplist containing Dough and Madrigal).

Comment 1

[Stephen P. Morse]

Without even trying this, I know exactly what is going wrong.  And it might not 
be easy to fix but I'll give it a try.

Aside from the implementation difficulties of enumerating all possible 
choices when concatenation rules are involved, there is yet another problem.  
Namely, if I tried to list all possible rules, you would get the following 
drop-down list:

   Jane Dough
   Jane Madrigal
   Anna Dough
   Anna Madrigal

From the user's point of view, this might be worse than giving only one choice.

Comment 2

[Stephen P. Morse]

Despite my initial reservations, I was able to come up with a fix for this.  
Changes are in wallet.cpp.

Rather than enumerating all possible combinations of the values of fields found 
in combination rules (first name and last name in the example given), I restrict 
the choices to first value of first name + first value of last name, second 
value of first name + second value of last name, etc.  That had two advantages 
-- it was a much easier fix to make and it avoided the probably-meaningless 
cross values.  In other words, if you enter and capture John Johnson and then 
Jane Janedaughter on the interview form, the values in the prefill dropdown list 
when you are on the amazon form will contain just those two values and will not 
contain John Janedaughter nor will it contain Jane Johnson.

Comment 3

[sairuh (rarely reading bugmail)]

looks good using today's opt comm bits, 2000.05.09.08 (mac,linux,winNT).