361175 - [PostgreSQL] Too many "NOTICE" messages from checksetup.pl

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Max Kanat-Alexander]

I *finally* found out today how to stop the "NOTICE" messages from printing in checksetup.pl:

$ENV{PGOPTIONS}='-c client_min_messages=warning'

Comment 1

[Olav Vitters]

man DBD::Pg has some information on how to set PGOPTIONS as a DBI connect 'options' parameter. I think that is cleaner than setting an environment variable.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

I assert that I've tested this, and that it does what it's supposed to do.

It's going to make Pg users so much happier. I hate those darn NOTICE messages.

So, Colin, could you just look this over and assert that it looks like perl?

Comment 3

[Colin Ogilvie [:cso]]

Comment on attachment 245915 [details] [diff] [review]
v1

r=me by inspection - looks like Perl to me.

Comment 4

[Max Kanat-Alexander]

Okay, actually, I'm going to go with bkor's suggestion instead.

Comment 5

[Max Kanat-Alexander]

Attachment: v2

Okay. It actually ended up being trivial to do it that way.

Comment 6

[Olav Vitters]

Comment on attachment 245916 [details] [diff] [review]
v2

Tested, works.

Comment 7

[Frédéric Buclin]

This would probably make sense to also commit this patch on the 2.22 branch, assuming the patch works there too (and with Pg 7.3.x!).

Comment 8

[Dave Miller [:justdave]]

I agree with LpSolit, go for this on 2.22 as well if it's applicable.

Comment 9

[Max Kanat-Alexander]

I used justdave's verbal approval above to check it in to 2.22, but we should also get the a2.22+ for this bug.

tip:

Checking in Bugzilla/DB/Pg.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Pg.pm,v  <--  Pg.pm
new revision: 1.23; previous revision: 1.22
done

2.22:

Checking in Bugzilla/DB/Pg.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Pg.pm,v  <--  Pg.pm
new revision: 1.18.2.1; previous revision: 1.18
done