361245 - Deleting history items from search results is slow

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: History, defect)

Description

[Chris Lawson (gone)]

Specifically, it takes about 0.1 sec to delete each individual history item, and deleting more than 15-20 history items causes beachballing on a 1.5 GHz PPC G4 with 2 GB RAM.

Sample coming.

If there's something obvious we can do to help this out, it'd be nice to get it into 1.1, but I'm certainly not holding my breath.

Comment 1

[Chris Lawson (gone)]

Attachment: Sample of Camino during beachball

Taken while deleting several hundred history items (maybe as many as a few thousand; I'm not sure).

Comment 2

[Chris Lawson (gone)]

See also the bookmarks version, bug 357080.

Comment 3

[Chris Lawson (gone)]

This is worst when a search string is entered in the search field. I use Wikipedia a lot, and I got a nice nine-minute beachball (where I took the sample) by entering "http://e" in the search field and then deleting almost all of the en.wikipedia.org URLs from history.

Doing a similar operation on 1.0.3 doesn't seem to be NEARLY as bad, so changing to trunk.

cl

Comment 4

[Chris Lawson (gone)]

This sucks on branch, too, using 2006121802 (1.1a1+), so perhaps it's a regression. I'll try to check it again with 1.0.3 in another couple weeks when I have a pile of accumulated Wikipedia URLs in history again.

Tweaking summary to be more accurate.

Comment 5

[Chris Lawson (gone)]

Mike, Simon --

Do you guys think a reasonable approach to this might be to hold off on re-sorting the search results until all the deletions are finished? Right now, we rebuild the search results on every call to |itemRemoved:|, which sucks for obvious reasons.

cl

Comment 6

[Chris Lawson (gone)]

Taking to keep it on my radar. I have some notes on the PBG4 about this bug from when I did investigation on it earlier that I need to post here, too.

Comment 7

[Ed Avis]

(I am torn between opening a new bug for this and commenting here - if general slowness is a separate issue, I'll go elsewhere.)

I would suggest that deleting history items in general is slow.  Deleting about 50000 history items, on a fast machine, causes Firefox to hang chewing CPU for a long time (I killed it after a few hours).  Worse, the whole process is locked up while this happens.  The history view window did not have a search, but it was sorted by Location.

I would suggest that at the minimum, some kind of progress bar and cancel button is needed for these lengthy delete operations.

Comment 8

[Ed Avis]

Sorry - just saw that product=Camino, I was using Firefox, please disregard.

Comment 9

[Takanori MATSUURA]

This bug lies at rest in the graveyard.