361285 - nocachedbodybody property in messenger.properties is missing a space between "Offline." and "In the future".

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[(not reading, please use [e-mail] instead)]

nocachedbodybody property in messenger.properties is missing a space between "Offline." and "In the future".

it says:  "...the File menu and then uncheck Work Offline.In the future..."

it should have:  "...the File menu and then uncheck Work Offline. In the future..."

I'm using version 2 beta 1 (20061110) on mac os x

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 2

[Scott MacGregor]

Let's fix this now before the string freeze.

Comment 3

[Scott MacGregor]

Axel, do I need to bump the string ID when fixing a typo in the en-US version of the string? (i.e. the missing space in this case). I guess it couldn't hurt to be extra aggressive about bumping the ID in case other locales copied the en-US string. They may have the same space problem. 

Comment 4

[Axel Hecht [:Pike]]

If they did, that's likely a problem per se.

Only semantic changes should use a new string, but it might be good to give a notice to those that have the en-US string in there, or something close. CC'ing Mark from en-GB.

Comment 5

[Scott MacGregor]

Attachment: fix for the branch

Since seamonkey has a string freeze, I had to ifdef out the code to use the new ID for this string so it's Thunderbird only.

Comment 6

[Scott MacGregor]

Comment on attachment 246067 [details] [diff] [review]
fix for the branch

removing the patch request. I didn't read Axel's comment that we shouldn't bump the id before I posted the patch.

Comment 7

[Scott MacGregor]

Attachment: the fix

Add a space without changing the entity id.