361376 - Right click on an item in the Add-Ons dialog produces a context menu on the left hand side of the dialog

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Ryan Jones-Ward [:sciguyryan]]

[Originally found here: http://forums.mozillazine.org/viewtopic.php?t=490762]

When opening the Add-Ons dialog, right clicking an item produces a popup menu on the left hand side of the dialog rather than where the click occured. (See screenshot above)

Suggestions are that bug #354694 was the cause and the regression time frame was between the 111611 2nd nightly and the 111704 nightly.

If this is in the wrong component please move it.

Comment 1

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061120 Minefield/3.0a1
Same observed in the downloads window once it's populated with at least one download.

Comment 2

[Steve England [:stevee]]

From the forum, regression range between 2006111611 and 2006111704

Bonsai
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-11-16+11%3A00%3A00&maxdate=2006-11-17+06%3A00%3A00&cvsroot=%2Fcvsroot

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

doesn't happen in linux.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

I've confirmed by local backout that bug 354694 is responsible for this regression.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

ok, I know what the problem is. Now I just have to find where in windows 
code contextmenu event is dispatched in a bit wrong way...

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

I have a patch and someone is going to test it on Windows 
(I have only Linux dev. machines)

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: possible patch

I've been told that this fixes the problem.

Comment 8

[Ere Maijala (slow)]

Comment on attachment 246277 [details] [diff] [review]
possible patch

Whoever told you that was correct :)

r=emaijala

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Checked in. Someone with a Windows build, please test and mark this fixed.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Gavin said this is now fixed.

Comment 11

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061122 Minefield/3.0a1 ID:2006112222 [cairo]

VERIFIED