361423 - Executable attributes/permissions on files that shouldn't be executable.

Status: RESOLVED DUPLICATE of bug 513900

(SeaMonkey :: Build Config, defect)

Description

[[:Aleksej]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.8) Gecko/20061029 SeaMonkey/1.0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.8) Gecko/20061029 SeaMonkey/1.0.6

Many non-executable files in the products' distributions have the x attribute set.
For example:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1) Gecko/20061120 BonEcho/2.0
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061120 Minefield/3.0a1
*.so
*.xpm
defaults/profile/prefs.js
searchplugins/*
icons/*

Thunderbird version 2 beta 1 (20061121) Linux
Thunderbird version 3 alpha 1 (20061121) Linux
*.so
*.xpm
LICENSE.TXT
components/newsblog.js
defaults/profile/prefs.js

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.8) Gecko/20061029 SeaMonkey/1.0.6
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20061121 SeaMonkey/1.5a
*.so


Reproducible: Always

Steps to Reproduce:
1. Get a no-installer archive of one of the products (probably the installers have this problem, too).
2. Unpack the archive or enter it using mc or something else.
3. Check the executable attributes.

Actual Results:  
There are too many.

Expected Results:  
The attributes should be set only on the files that are to be executed from command line.

Comment 1

[Andrew Schultz]

libraries (.so) should have the execute bit set.  Take a look in /usr/lib/

Comment 2

[[:Aleksej]]

1. They seem to work fine without it.
2. LICENSE.TXT and *.xpm definitely shouldn't.

Comment 3

[[:Aleksej]]

Still so with
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a5pre) Gecko/20070505 Minefield/3.0a5pre
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.4pre) Gecko/20070505 BonEcho/2.0.0.4pre
Thunderbird version 3.0a1 (20070505)
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a5pre) Gecko/20070505 Calendar/0.6a1

Comment 4

[[:Aleksej]]

Still so with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a8pre) Gecko/2007090904 Minefield/3.0a8pre

Comment 5

[[:Aleksej]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081021 Minefield/3.1b2pre
defaults/profile/prefs.js
*.so
icons/*
blocklist.xml

Comment 7

[[:Aleksej]]

There is a patch in bug 461322: attachment 344456 [details] [diff] [review].

Comment 8

[[:Aleksej]]

Only the .so files have the executable but set in:
* Firefox 3.5.4 (en-US, eo)
* Thunderbird 3.0b4 (en-US)

In SeaMonkey 2.0 (en-US, ru) and 1.9.3a1pre 20091103001651, license.txt is still executable.

Comment 9

[Robert Kaiser]

Ideas and/or patch would be appreciated!

Comment 10

[Justin Wood (:Callek)]

Duping forward ONLY because that bug has more data in it at this moment.