The default bug view has changed. See this FAQ.

gre should be installed locally

RESOLVED FIXED

Status

SeaMonkey
Installer
--
minor
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Benoît, Assigned: Benoît)

Tracking

({fixed-seamonkey1.1})

1.8 Branch
x86
Windows XP
fixed-seamonkey1.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.09 KB, patch
Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com]
: review+
neil@parkwaycc.co.uk
: superreview+
Robert Kaiser
: approval-seamonkey1.1+
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
With the move to XULRunner, the shared GRE method of the old Mozilla Application Suite is pretty much obsolete. The GRE should be locally installed now.
(Assignee)

Comment 1

11 years ago
Created attachment 246218 [details] [diff] [review]
changes GRE_Type to "Local"
Attachment #246218 - Flags: superreview?(dveditz)
Attachment #246218 - Flags: review?(dveditz)
(Assignee)

Updated

11 years ago
Attachment #246218 - Flags: superreview?(neil)
Attachment #246218 - Flags: superreview?(dveditz)
Attachment #246218 - Flags: review?(dveditz)
Attachment #246218 - Flags: review?(cst)

Updated

11 years ago
Attachment #246218 - Flags: superreview?(neil) → superreview+
I can't build a working installer, so I can't test this patch.
(Assignee)

Comment 3

11 years ago
I tested my patch, and it works fine. GRE is installed in the install directory, not in Common Files\mozilla.org (or elsewhere for that matter). SeaMonkey runs fine. Uninstallation also successfully removes the GRE.
Status: NEW → ASSIGNED
Comment on attachment 246218 [details] [diff] [review]
changes GRE_Type to "Local"

Code looks fine.  I couldn't test it myself.
Attachment #246218 - Flags: review?(cst) → review+
(Assignee)

Comment 5

11 years ago
Comment on attachment 246218 [details] [diff] [review]
changes GRE_Type to "Local"

In addition to making things more tidy, there's other advantages to the GRE being installed in the application directory.

At least on Windows, instead of having to re-download the whole package again (a hassle for dial-up users), the SeaMonkey Council or a third party could provide a simple executable that removes changed GRE files and replaces them by the patched ones.

This is how the K-Meleon project handles security updates when it's not fixing K-Meleon-specific things at the same time.
Attachment #246218 - Flags: approval-seamonkey1.1?
(Assignee)

Comment 6

11 years ago
I didn't assign myself yet, even though the status says the bug is. Doing so now.
Assignee: nobody → benoit
Status: ASSIGNED → NEW

Comment 7

10 years ago
fixed on trunk
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 8

10 years ago
Comment on attachment 246218 [details] [diff] [review]
changes GRE_Type to "Local"

a=me/CTho (via IRC) for SeaMonkey 1.1
Attachment #246218 - Flags: approval-seamonkey1.1? → approval-seamonkey1.1+
Checked in on branch.
Keywords: fixed-seamonkey1.1

Updated

10 years ago
Depends on: 368264
You need to log in before you can comment on or make changes to this bug.