361448 - Feed processor logs an exception when it hits an unknown element in atom:author

Status: VERIFIED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Robert Sayre]

the exception is harmless, because the SAX processor keeps going.

Comment 1

[Robert Sayre]

Attachment: check for an undefined prefix (namespaces we don't know about)

Comment 2

[Asaf Romano (gone)]

Comment on attachment 246229 [details] [diff] [review]
check for an undefined prefix (namespaces we don't know about)

r=mano

Comment 3

[Robert Sayre]

Checking in src/FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.22; previous revision: 1.21
done
RCS file: /cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/author_namespaces.xml,v
done
Checking in test/xml/rfc4287/author_namespaces.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/author_namespaces.xml,v  <--  author_namespaces.xml
initial revision: 1.1
done

Comment 4

[Jay Patel [:jay]]

Comment on attachment 246229 [details] [diff] [review]
check for an undefined prefix (namespaces we don't know about)

Approved for the 1.8 branch, a=jay for drivers.

Comment 5

[Robert Sayre]

Checking in test/xml/rfc4287/author_namespaces.xml;
/cvsroot/mozilla/toolkit/components/feeds/test/xml/rfc4287/author_namespaces.xml,v  <--  author_namespaces.xml
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in src/FeedProcessor.js;
/cvsroot/mozilla/toolkit/components/feeds/src/FeedProcessor.js,v  <--  FeedProcessor.js
new revision: 1.1.2.15; previous revision: 1.1.2.14
done

Comment 6

[alice nodelman [:alice] [:anode]]

This bug is marked [need testcase].

Is there a series of steps to be followed that would confirm the fix?

If there is a method of verifying the bug, could you either provide a
description/testcase or test the latest builds?  If you confirm the fix please
provide the buildid that you verified it on and change the keywords from
fixedx.x.x.x to verifiedx.x.x.x.

Comment 7

[Phil Ringnalda (:philor)]

Personally, I like "cd objdir/toolkit/components/feeds/; make check" for verification, but failing that, the steps-to-verify are 1. Set javascript.options.showInConsole to true, 2. Load http://www.intertwingly.net/blog/2485.atom, 3. Observe the lack of "Error: gNamespaces[uri] has no properties" spew in the console, 4. Say "verified with 20070201 trunk and 2.0.0.2pre bits" 5. Twiddle some form controls.