361650 - Default event start time is 00:00 and not the next full hour

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Andreas Treumann]

REPRODUCTION:
=============

- choose File -> New... -> Event


RESULT:
=======

- the default start time is 0:00

EXPECTED RESULT:
================

Start time has to be on the next full hour. E.g. it is 9:40am the preselected time has to be 10:00am.

REPRODUCIBLE:
=============

- always

Comment 1

[Stefan Sitter [:ssitter]]

I mentioned this issue as a side note in Bug 360821 Comment #0, the regression range is the same as in Bug 360821. Probably also regressed by the checkin for Bug 346934.

Comment 2

[Koen Hendrickx]

I see this is indicated as Lightning only, but with Sunbird nightly 2006-12-05 (linux) i got the same problem...

Comment 3

[Stefan Sitter [:ssitter]]

Regression range:
 Works in Lightning/0.4a1 (2006110607); Fails in Lightning/0.4a1 (2006110708)
 Works in Sunbird/0.4a1 (2006110607);   Fails in Sunbird/0.4a1 (2006110706)

Comment 4

[Joey Minta]

Attachment: tidy things up

Tidying up a bunch of functions here.  If we don't have a startDate, or if the date is an all-day event (and hence came from the controller), we should set the hour.

Comment 5

[Matthew (lilmatt) Willis]

Comment on attachment 247590 [details] [diff] [review]
tidy things up

r=lilmatt

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 247590 [details] [diff] [review]
tidy things up

>Index: calendar/base/content/calendar-item-editing.js
>     if (!startDate) {
>         startDate = currentView().selectedDay.clone();
>+        startDate.isDate = true;
>+    }
>+    if (startDate.isDate) {
>         startDate = startDate.clone();

That means that without a startdate, you will clone twice. You should avoid that. It's overkill.

r2=mvl with that fixed.

Comment 7

[Joey Minta]

Patch checked in, with nits picked.

Comment 8

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061211 Calendar/0.4a1

Comment 9

[Damian Szczepanik]

Litmus testcase 3020 created