361757 - Saved passwords are not reused if realm contains umlauts

Status: RESOLVED INCOMPLETE

(Calendar :: Provider: ICS/WebDAV, defect)

Description

[Lothar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1pre) Gecko/20061123 BonEcho/2.0.0.1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.1pre) Gecko/20061123 BonEcho/2.0.0.1pre

Maybe its related to bug 343721 or not even unique to calendar.

Passwords to WebDAV Servers are saved within the password manager (if desired) but are NOT reused after program restart! The password prompts again with empty fields and this input will be saved again at the signons.txt with the exact same data (if desired). Further entries will have empty server address (only username and password)!
It's very likely that this is an umlaut (הצ�) problem, see the realm below, it contains an "�". No problem if the realm looks like "(EMO-DAV)". Works also if the calendar is added without password manager:
https://username:[e-mail]/calendarfile.ics

Entry at signons.txt:
 webdav.smartdrive.web.de:443 (Bitte geben Sie die Nutzerdaten f�r den WEB.DE-Account ein, auf dessen WEB.DE SmartDrive Sie zugreifen wollen.)
 \=username=\
 ~abcd1234
 *\=password=\
 ~12345ABDCE
 .

No help if the entry is edited to
 https://[e-mail] (Bitte geben Sie die Nutzerdaten f�r den WEB.DE-Account ein, auf dessen WEB.DE SmartDrive Sie zugreifen wollen.)
 \=username=\
 ~
 *\=password=\
 ~12345ABDCE
 .



Reproducible: Always

Steps to Reproduce:
1. Add calendar via WebDAV to https://webdav.smartdrive.web.de/calendar.ics
2. Enter username and passwort at the prompt and save it
3. Close and restart Thunderbird

Actual Results:  
Username and password are prompted again.

Expected Results:  
Username and password should used from password manager and no new entry should be added.

Used builds:
 - Mail/News v2b1 (20061121) with lightning 04a1 (2006112111)
 - Thunderbird Version 1.5.0.8 (20061025) with Lightning 0.3
Different profiles used.

Comment 1

[Lothar]

Works from 
"Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1) Gecko/20061010 Firefox/2.0" to 
"Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061124 Minefield/3.0a1".
The username and password fields of the dialog are filled in displayed after restart.
TB and Mail/News seem to use an old version of the password manager?

Comment 2

[Stefan Sitter [:ssitter]]

Lothar, Bug 343721 was fixed some days ago. Does the problem still exist in a current Sunbird nightly build?

Comment 3

[Lothar]

(In reply to comment #2)
> Lothar, Bug 343721 was fixed some days ago. Does the problem still exist in a
> current Sunbird nightly build?

Tested with:
Mail/News Client version 3 alpha 1 (20061215) & (20061219) + Lightning 0.4a1 build 2006121905 (Windows builds)
from ftp://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/

No, it became still worse, WebDAV with umlauts still has this strange behavior PLUS FTP calender aren't handled any more and forwarded to the browser! :/
In short:

Still working:
 https://user:pass@server/cal.ics
 https://server/cal.ics (without umlauts at realm)

Not any more working:
 ftp://username@server/cal.ics
 ftp://user:pass@server/cal.ics (error 0x80004002)

Not working before:
 https://server/cal.ics (realm contains umlauts)

So even less functionality.
Should I request reopening Bug 343721 or file a new one?

Comment 4

[Simon Paquet [:sipaq]]

(In reply to comment #3)
> Tested with:
> Mail/News Client version 3 alpha 1 (20061215) & (20061219) + Lightning 0.4a1
> build 2006121905 (Windows builds)
> from ftp://ftp.mozilla.org/pub/mozilla.org/calendar/lightning/nightly/
> 
> No, it became still worse, WebDAV with umlauts still has this strange behavior
> PLUS FTP calender aren't handled any more and forwarded to the browser! :/

Lightning in Thunderbird does not support the FTP protocol.

Comment 5

[Lothar]

(In reply to comment #4)
> Lightning in Thunderbird does not support the FTP protocol.

Interesting, I have a working version here: TB 2b1 nightly (20061219) with Lightning 0.4a1 build 2006121403 and an older version at home. Plus see Bug 312533 and Bug 273476.
Do u mean "not any more"? And if so, why is it taken out?

Comment 6

[Matthew (lilmatt) Willis]

(In reply to comment #5)
> Do u mean "not any more"? And if so, why is it taken out?
No. Lightning has never "added" support for FTP to Thunderbird.

If it _did_ work before, it's due to that particular Thunderbird build having support for FTP in its networking code, not Lightning.  Also note that we (the Calendar team) don't decide what networking code Thunderbird does or does not ship (although we have mentioned it to the Tb folks in the past).

Regardless, this bug is about umlauts in the HTTP auth realm.  Morphing or distracting the bug from that goal will likely not help in getting a fix in place.

Could you try to reproduce this bug in a recent Sunbird (not Lightning) nightly? I'm interested to know if this is a bug in our code, or if it is due to Thunderbird still using wallet (which is old) and not toolkit's password manager (like Fx and Sb).

Comment 7

[Lothar]

(In reply to comment #6)
[...]
> Could you try to reproduce this bug in a recent Sunbird (not Lightning)
> nightly? I'm interested to know if this is a bug in our code, or if it is due
> to Thunderbird still using wallet (which is old) and not toolkit's password
> manager (like Fx and Sb).
Thanks for your annotations, Matthew.

Test result for "Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20061220 Calendar/0.4a1".
Works for me! And, sry I couldn't resist ;) FTP-calendar is working, too.

Only one less nice thing: if passwords are not saved at PM, both ftp and webdav password input windows appearing above each other, but iirc this is already at work.
I'm attaching a PM screenshot, so you can see, that the umlaut is handled correctly here.

Pls advise further steps, maybe you could file a more precise new bug (if so pls let me know)...

Comment 8

[Lothar]

Attachment: Sunbird nightly PM window with saved passwords

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20061220 Calendar/0.4a1

Two passwords are now successfully saved, one for a calendar stored at a FTP and one at a WebDAV server which realm contains umlauts.

Comment 9

[Matthew (lilmatt) Willis]

(In reply to comment #7)
> FTP-calendar is working, too.
Yes, we include FTP support in Sunbird.  It's Thunderbird we don't have control over. :)

> Pls advise further steps, maybe you could file a more precise new bug (if so
> pls let me know)...
This seems like a bug in Thunderbird's password manager more than anything, and Thunderbird uses the old password manager from wallet.  There's likely a duplicate bug on file somewhere about this.

I'm CCing mscott (Mr. Thunderbird) to see if he can shed any light and to see if this bug should be moved over to Thunderbird and/or marked as blocked by a "migrate Thunderbird password manager to toolkit" bug if one exists.

Comment 10

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #9)
> This seems like a bug in Thunderbird's password manager more than anything, and
> Thunderbird uses the old password manager from wallet.  There's likely a
> duplicate bug on file somewhere about this.
> 
> I'm CCing mscott (Mr. Thunderbird) to see if he can shed any light and to see
> if this bug should be moved over to Thunderbird and/or marked as blocked by a
> "migrate Thunderbird password manager to toolkit" bug if one exists.
> 

CC'ing dmose to see if he can shed any light on this as well.

Comment 11

[Philipp Kewisch [:Fallen][☁️📆]]

Does this still happen with the latest 1.0b2pre nightlies?

Comment 12

[Philipp Kewisch [:Fallen][☁️📆]]

No response for a while now, closing INCOMPLETE. Please reopen if you can reproduce or answer any unanswered questions.