361865 - OutputStream should be closed after writing new entries to Junklog.html

Status: RESOLVED DUPLICATE of bug 231923

(MailNews Core :: Backend, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

version 2 beta 1 (20061125)

The junk mail controls don't close the file junklog.html after writing a new entry. So you don't have access to that file from the file system and other Thunderbird dialogs like junk mail log. Thunderbird blocks itself.

Before any message is marked as junk I can delete the junklog.html manually on the file system. Afterwards I cannot get any access to it until I close Thunderbird. The file is blocked.

Even Thunderbird isn't able to delete the log by pressing the button "Clear log" inside the "Junk Mail Log" dialog. Doing that shows following Exception inside the Error Console:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.remove]"  nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)"  location: "JS frame :: chrome://messenger/content/preferences/junkLog.js :: clearLog :: line 29"  data: no]

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The OutputStream in function LogJunkString which we use to write new entries to junklog.html isn't closed after writing.

http://lxr.mozilla.org/seamonkey/source/mailnews/base/src/nsSpamSettings.cpp#585

=> Mailnews

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

*** Bug 356835 has been marked as a duplicate of this bug. ***

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

why does releasing the reference not close it?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #3)
> why does releasing the reference not close it?

It was just an idea. I don't know the source as good as you.

Comment 5

[Serge Gautherie (:sgautherie)]

Could be related/duplicate to bug 231923 ?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Is this really a dupe or should we add this bug as depends of bug 231923?