Use of uninitialized value in numeric eq (==) at Bugzilla/User.pm line 1465

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
Email Notifications
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

({regression})

2.23.3
Bugzilla 3.0
regression
Bug Flags:
approval +

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
sub wants_mail {

    # Skip DB query if relationship is explicit
    return 1 if $relationship == REL_GLOBAL_WATCHER;
    
    my $dbh = Bugzilla->dbh;
    
    # If a relationship isn't given, default to REL_ANY.
    if (!defined($relationship)) {
        $relationship = REL_ANY;
    }


We should first set $relationship to REL_ANY if it's undefined, then check if its value is REL_GLOBAL_WATCHER.
(Assignee)

Comment 1

12 years ago
Created attachment 246612 [details] [diff] [review]
patch, v1
Attachment #246612 - Flags: review?(bugzilla-mozilla)

Updated

12 years ago
Attachment #246612 - Flags: review?(bugzilla-mozilla) → review+

Updated

12 years ago
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval? → approval+
(Assignee)

Comment 2

12 years ago
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.143; previous revision: 1.142
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.