361942 - Two Australian holidays shown on incorrect dates

Status: RESOLVED FIXED

(Calendar :: Website, defect)

Description

[Luke Manhood]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en) AppleWebKit/418.9 (KHTML, like Gecko) Safari/419.3
Build Identifier: Apple iCal 2.0.4

The Australian Holidays calendar listed on  http://www.mozilla.org/projects/calendar/holidays.html with URL webcal://www.mozilla.org/projects/calendar/caldata/AUHolidays.ics has two date errors in it for 2007 that I have noticed.

ANZAC day is currently shown as being on the 24th of April 2007, when it should in fact be on the 25th of April 2007, and Melbourne Cup Day is shown on the 5th of November 2007, when it should in fact be on the 6th of November 2007 (the first Tuesday in November).

Reproducible: Always

Steps to Reproduce:
1. Subscribing to the calendar.
2.
3.

Actual Results:  
As above

Expected Results:  
As listed in "Details"

Comment 1

[Martin Schröder [:mschroeder]]

*** Bug 361943 has been marked as a duplicate of this bug. ***

Comment 2

[Randall]

Please also add
12 March 2007  Adelaide Cup Day(SA)

Comment 3

[Randall]

Attachment: Updated AUHolidays file with corrections

Corrected dates for Anzac Day, Melbourne Cup day

Added Adelaide Cup Day

Comment 4

[Simon Paquet [:sipaq]]

Checked in. Thanks for your contribution.

Comment 5

[Cameron]

eh, I was gunna make ya a patch, but whatever :P

Comment 6

[Luke Manhood]

In my subscribed calendar in iCal I can see that Melbourne Cup Day has been fixed, and Adelaide Cup day added, but Anzac Day is still showing on the 24th of April 2007 when it should be on the 25th of April.

Also there is a second, incorrect, entry for Adelaide Cup day on 21 May 2007 which should be removed.

Comment 7

[Randall]

Attachment: More corrections..

Corrected Anzac Day to April 25 2007
Removed incorrect entry for Adelaide Cup day on May 21 2007

Comment 8

[Simon Paquet [:sipaq]]

Fix checked in. Thanks for your contribution and a merry christmas to you.

Comment 9

[Frank De Fazio]

Attachment: Latest AU Calendar file - all holidays 2006 to 2008

Hi Guys - I am the culprit to those errors noted on this bug - sorry. I have updated the latest AU Holidayt file to include the latest known holidays from the state govt websites. My plan is to update every year around this time.

I have deleted the 2005 and earlier holidays as they had some inherent errors in them that were creating issues. And I have given up on using recurrences at this stage as they just create too many issues.

Regards - Frank De Fazio

Comment 10

[Simon Paquet [:sipaq]]

(In reply to comment #9)
> Created an attachment (id=250160) [details]
> Latest AU Calendar file - all holidays 2006 to 2008 

File checked in. Thanks again.