Closed Bug 361980 Opened 13 years ago Closed 13 years ago

Clean up "my" variable scoping, take 2

Categories

(Bugzilla :: Bugzilla-General, defect, major)

2.23.3
defect
Not set
major

Tracking

()

RESOLVED INVALID

People

(Reporter: justdave, Unassigned)

Details

This was originally bug 173629, which is now marked fixed, with a huge checkin.

However the problem is still very much present.  These were either missed, or are new ones introduced since that was fixed.

Variable "$bugid" will not stay shared at /opt/webtools/bugzilla-test/attachment-canconfirm.cgi line 185.
Variable "$cgi" will not stay shared at /opt/webtools/bugzilla-test/attachment-canconfirm.cgi line 288.
Variable "$cgi" will not stay shared at /opt/webtools/bugzilla-test/attachment-canconfirm.cgi line 341.
Variable "$cgi" will not stay shared at /opt/webtools/bugzilla-test/attachment-canconfirm.cgi line 372.
Variable "$filename" will not stay shared at /opt/webtools/bugzilla-test/attachment-canconfirm.cgi line 375.
Variable "$cgi" will not stay shared at /opt/webtools/bugzilla-test/attachment-canconfirm.cgi line 444.
Variable "$cgi" will not stay shared at /opt/webtools/bugzilla-test/attachment-canconfirm.cgi line 518.
Variable "$cgi" will not stay shared at /opt/webtools/bugzilla-test/attachment-canconfirm.cgi line 668.
Variable "$cgi" will not stay shared at /opt/webtools/bugzilla-test/attachment-canconfirm.cgi line 702.
Variable "$filename" will not stay shared at /opt/webtools/bugzilla-test/attachment-canconfirm.cgi line 834.
Variable "@weekday" will not stay shared at /opt/webtools/bugzilla-test/buglist-bm.cgi line 204.
Variable "$columns" will not stay shared at /opt/webtools/bugzilla-test/buglist-bm.cgi line 422.
Flags: blocking3.0+
It would probably be a good idea to track down who introduced these and add them to the CC on this bug just so they remember this stuff going forward.  There's more things to learn when doing mod_perl-compatible code. :)

Maybe we need to come up with a test that tests for this, too.
pfft
these are local files on the copy of bmo I grabbed, they're not in CVS.

Ignore me.
No longer blocks: mod_perl
Status: NEW → RESOLVED
Closed: 13 years ago
No longer depends on: 173629
Resolution: --- → INVALID
Flags: blocking3.0+
You need to log in before you can comment on or make changes to this bug.