362047 - [regression] DomInspector opens with blank pane, cannot inspect nodes

Status: VERIFIED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[philippe (part-time)]

Open up the Dom Inspector. It only shows blank empty panes. 
It is not possible to inspect a node.

Works:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20061127 Minefield/3.0a1 ID:2006112704

fails
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20061127 Minefield/3.0a1 ID:2006112717

Comment 1

[philippe (part-time)]

Attachment: Screenshot

Comment 2

[Shawn Wilsher :sdwilsh]

Any errors in the JS console?  Is this a nightly or custom build?

Comment 3

[philippe (part-time)]

(In reply to comment #2)
> Any errors in the JS console?  Is this a nightly or custom build?
> 
With the newest build (2006112717): nothing in the error console. 

With the oldest of the two builds (2006112704), I had 2 errors:
No chrome package registered for chrome://communicator/content/utilityOverlay.xul .
No chrome package registered for chrome://communicator/content/tasksOverlay.xul 
But DomI worked correctly.

Those a official builds, the 2006112704 build is the nightly, the 2006112717 is a tinderbox build, from
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/xserve06-trunk/

Comment 4

[Phil Ringnalda (:philor)]

Works fine in a --enable-default-toolkit=cocoa build out of the same tree where I just built a --enable-default-toolkit=cairo-cocoa build that failed, so at first glance I'd say this is something in today's Cairo checkins.

Comment 5

[Shawn Wilsher :sdwilsh]

The only checkin with DOMI today that I can see affecting this is Bug 361105, but I don't think that's it.  I'm hoping it is the suggestion from Comment 4.

Comment 6

[Phil Ringnalda (:philor)]

Nope, bug 361146 - you were missing a ) in the last line. Fixed as bustage with irc-r=timeless.

(Doesn't anyone build with patches to test them? Or enforce 80 columns, so they see the ends of lines?)

Comment 7

[philippe (part-time)]

Thanks, Phil

Comment 8

[philippe (part-time)]

Verified with:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1) Gecko/20061128 Minefield/3.0a1 ID:2006112802

Comment 9

[Shawn Wilsher :sdwilsh]

(In reply to comment #6)
> Nope, bug 361146 - you were missing a ) in the last line. Fixed as bustage with
> irc-r=timeless.
> 
> (Doesn't anyone build with patches to test them? Or enforce 80 columns, so they
> see the ends of lines?)

I build (the first patch didn't cause any issues for me), and jar.mn files can't have newlines until the line is done as far as I know.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

I fixed the bustage fix, the paren was added in the wrong place (setAccessibleNodes takes two params, PrefUtils.getPref takes one).