Closed
Bug 362074
Opened 19 years ago
Closed 19 years ago
ns*TextFieldAccessible::CheckForEditor should use nsIDOMNSEditableElement
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: asaf, Assigned: asaf)
Details
Attachments
(1 file)
|
3.96 KB,
patch
|
aaronlev
:
review+
|
Details | Diff | Splinter Review |
nsXULTextFieldAccessible::CheckForEditor and nsHTMLTextFieldAccessible::CheckForEditor go through nsITextControlFrame for achieving the element's editor. They could simply use nsIDOMNSEditableElement.
|
Assignee | |
Updated•19 years ago
|
Assignee: aaronleventhal → mano
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #246801 -
Flags: review?(aaronleventhal)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 246801 [details] [diff] [review]
patch
+ nsresult rv = editableElt->GetEditor(getter_AddRefs(editor));
+ if (NS_SUCCEEDED(rv)) {
+
I recommend getting rid of |rv| and using
if (editor) {
SetEditor(editor);
}
Attachment #246801 -
Flags: review?(aaronleventhal) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
I don't think that would be right, SetEditor takes care of that case.
|
|
||
Comment 4•19 years ago
|
||
Fair enough.
|
|
Assignee | |
Comment 5•19 years ago
|
||
mozilla/accessible/src/html/nsHTMLFormControlAccessible.cpp 1.76
mozilla/accessible/src/xul/nsXULFormControlAccessible.cpp 1.66
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [19a1]
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [19a1]
You need to log in
before you can comment on or make changes to this bug.
Description
•