362080 - [Mac a11y] Make popupmenus accessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[Håkan Waara]

Comment 1

[Håkan Waara]

Attachment: Implement popupbutton class v1

Here's a initial implementation of a class that'll handle popupbuttons and popupmenus. Right now it handles ROLE_COMBOBOX, which is popupmenus (menulists).

I corrected the rolelist to some new info I got from Aaron. 

Also, there is currently no action on ROLE_COMBOBOX to show the child menu, so I can't implement that right now.

The class has the attributes from the spec: http://tinyurl.com/yfh9kq

I might reuse this class for all buttons that popup a menu (like Back/Forward buttons) later, if I figure out how to do that...

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 247523 [details] [diff] [review]
Implement popupbutton class v1

> I corrected the rolelist to some new info I got from Aaron. 

>-  NSAccessibilityComboBoxRole,                  // ROLE_COMBOBOX
>-  NSAccessibilityComboBoxRole,                  // ROLE_DROPLIST
>+  NSAccessibilityPopUpButtonRole,               // ROLE_COMBOBOX
>+  NSAccessibilityUnknownRole,                   // ROLE_DROPLIST. so far unused

Why droplist isn't used? Technically droplist is combobox that shows calendar in popup menu. Why can't you use NSAccessibilityPopUpButtonRole for it too?

>-  NSAccessibilityPopUpButtonRole,               // ROLE_BUTTONDROPDOWN
>+  NSAccessibilityUnknownRole,                   // ROLE_BUTTONDROPDOWN. so far unused

Why?

The rest looks good. r+ with those answered.

Comment 3

[Håkan Waara]

(In reply to comment #2)
> (From update of attachment 247523 [details] [diff] [review] [edit])
> > I corrected the rolelist to some new info I got from Aaron. 
> 
> >-  NSAccessibilityComboBoxRole,                  // ROLE_COMBOBOX
> >-  NSAccessibilityComboBoxRole,                  // ROLE_DROPLIST
> >+  NSAccessibilityPopUpButtonRole,               // ROLE_COMBOBOX
> >+  NSAccessibilityUnknownRole,                   // ROLE_DROPLIST. so far unused
> 
> Why droplist isn't used? Technically droplist is combobox that shows calendar
> in popup menu. Why can't you use NSAccessibilityPopUpButtonRole for it too?

Droplist isn't used in any code, according to LXR, that's why. Will it work just like a popupmenu? I.e., be a button that will pop up a menu? If so, I could make it the popupbutton role, I guess...

> >-  NSAccessibilityPopUpButtonRole,               // ROLE_BUTTONDROPDOWN
> >+  NSAccessibilityUnknownRole,                   // ROLE_BUTTONDROPDOWN. so far unused
> 
> Why?

Seems like right now it's only used by the colorpicker. I suppose I could use the popupbutton role for it too, if it has the same behavior.

One problem is that with all these small variations of widgets, it's quite hard to test for me. 

Comment 4

[Håkan Waara]

Attachment: Simple testcase

Simple XUL document with popupmenus that I used for testing.

Comment 5

[Håkan Waara]

Attachment: Patch with Alex's comments addressed

Comment 6

[alexander :surkov (:asurkov)]

(In reply to comment #3)

> Droplist isn't used in any code, according to LXR, that's why. Will it work
> just like a popupmenu? I.e., be a button that will pop up a menu? If so, I
> could make it the popupbutton role, I guess...

Yes, droplist is textfield and button to show popup calendar. The bug 349644 make droplist used.

Comment 7

[Håkan Waara]

Checked in.