If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Restore onerrorcommand autocomplete handlers

RESOLVED INVALID

Status

SeaMonkey
Autocomplete
RESOLVED INVALID
11 years ago
11 years ago

People

(Reporter: Andrew Schultz, Assigned: Andrew Schultz)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.36 KB, patch
neil@parkwaycc.co.uk
: review-
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
I removed onerrorcommand as part of bug 255731 at Neil's suggestion (bug 255731 comment 7), but I now think that was not the right thing to do.

autocomplete still tries to fire it
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/components/autocomplete/resources/content/autocomplete.xml&rev=1.136&mark=869,970#869

and some consumers still try to set an actual handler
http://lxr.mozilla.org/seamonkey/search?string=onerrorcommand
(Assignee)

Comment 1

11 years ago
Created attachment 246870 [details] [diff] [review]
patch
Assignee: nobody → ajschult
Status: NEW → ASSIGNED
Attachment #246870 - Flags: review?(neil)

Comment 2

11 years ago
Comment on attachment 246870 [details] [diff] [review]
patch

Hewitt removed support for onerrorcommand in revision 1.67 for some reason. If you really want to restore it you would also have to undo those changes.
Attachment #246870 - Flags: review?(neil) → review-
(Assignee)

Comment 3

11 years ago
He switched from using fireInit, fireTextCommand, fireErrorCommand and fireTextRevert methods to just a single _fireEvent method... but I don't see anything that actually removed support.

Comment 4

11 years ago
Yes, but that uses the attribute, not the field.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.