362253 - Support large files (>= 2GB) on FreeBSD.

Status: RESOLVED FIXED

(NSPR :: NSPR, enhancement)

Description

[Wan-Teh Chang]

NSPR should support large files (>= 2GB) on FreeBSD.

This requires defining the appropriate macro (_PR_HAVE_LARGE_OFF_T
or _PR_HAVE_OFF64_T) instead of _PR_NO_LARGE_FILES in
mozilla/nsprpub/pr/include/md/_freebsd.h.

Comment 2

[Makoto Kato [:m_kato]]

FreeBSD should use _PR_HAVE_LARGE_OFF_T because sizeof(off_t) is 8 even if 32-bit system.

Comment 3

[Makoto Kato [:m_kato]]

Attachment: patch

Comment 4

[Wan-Teh Chang]

Comment on attachment 427695 [details] [diff] [review]
patch 

r=wtc.  I verified that on FreeBSD 6.3 and 7.0, off_t is 64-bit:

<unistd.h> and <fcntl.h> have:
#ifndef _OFF_T_DECLARED
typedef __off_t         off_t;
#define _OFF_T_DECLARED
#endif

<sys/_types.h> has:
typedef __int64_t       __off_t;        /* file offset */

Comment 5

[Wan-Teh Chang]

I checked in the patch on the NSPR trunk (NSPR 4.8.5).

Checking in _freebsd.h;
/cvsroot/mozilla/nsprpub/pr/include/md/_freebsd.h,v  <--  _freebsd.h
new revision: 3.22; previous revision: 3.21
done