Autodiscovery should not discover rel="alternate stylesheet" as a feed

RESOLVED FIXED in Firefox 3 alpha2

Status

()

Firefox
RSS Discovery and Preview
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Lachlan Hunt, Assigned: Robert Sayre)

Tracking

({testcase})

unspecified
Firefox 3 alpha2
testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0

Web Apps 1 has clarified the definition of rel="alternate stylesheet" and the use of rel="alternate" for feed autodiscovery.  It states:

| if it does also contains the keyword stylesheet, the alternate keyword instead
| modifies the meaning of the stylesheet keyword in the way described for that
| keyword, and the rest of this subsection doesn't apply.

That means the definition for autodiscovery which is specified later in that subsection does not apply and a link like this should not be discovered.

<link rel="alternate stylesheet" type="application/atom+xml" href="/feed1" title="alternate stylesheet">

For further explanation, see
http://listserver.dreamhost.com/pipermail/whatwg-whatwg.org/2006-November/008054.html

This is also related to bug 362156.

Reproducible: Always

Steps to Reproduce:
1. Create a page with <link rel="alternate stylesheet" type="application/atom+xml" href="/feed1" title="alternate stylesheet">
2. Load it up and see if autodiscovery finds it.

(I tested this with the latest trunk as well)
Actual Results:  
The feed is discovered.

Expected Results:  
It shouldn't be.
(Reporter)

Comment 1

10 years ago
Created attachment 247042 [details]
Test case
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Assignee)

Updated

10 years ago
Assignee: nobody → sayrer

Updated

10 years ago
Keywords: testcase
(Assignee)

Updated

10 years ago
Target Milestone: --- → Firefox 3 alpha2
(Assignee)

Updated

10 years ago
Severity: enhancement → normal
(Assignee)

Comment 2

10 years ago
Created attachment 247558 [details] [diff] [review]
check for a stylesheet rel

I think this is fine for now, but instead of regexs, we should probably split(" ") the rel value into hash keys if we ever get around to combining the onLinkAdded handlers.
Attachment #247558 - Flags: review?(gavin.sharp)
Attachment #247558 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 3

10 years ago
Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.743; previous revision: 1.742
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.