Last Comment Bug 362329 - Autodiscovery should not discover rel="alternate stylesheet" as a feed
: Autodiscovery should not discover rel="alternate stylesheet" as a feed
Status: RESOLVED FIXED
: testcase
Product: Firefox
Classification: Client Software
Component: RSS Discovery and Preview (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 3 alpha2
Assigned To: Robert Sayre
:
Mentors:
http://whatwg.org/specs/web-apps/curr...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-11-29 22:00 PST by Lachlan Hunt
Modified: 2006-12-05 10:18 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Test case (553 bytes, text/html)
2006-11-29 22:02 PST, Lachlan Hunt
no flags Details
check for a stylesheet rel (1.09 KB, patch)
2006-12-05 10:11 PST, Robert Sayre
gavin.sharp: review+
Details | Diff | Review

Description Lachlan Hunt 2006-11-29 22:00:16 PST
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0

Web Apps 1 has clarified the definition of rel="alternate stylesheet" and the use of rel="alternate" for feed autodiscovery.  It states:

| if it does also contains the keyword stylesheet, the alternate keyword instead
| modifies the meaning of the stylesheet keyword in the way described for that
| keyword, and the rest of this subsection doesn't apply.

That means the definition for autodiscovery which is specified later in that subsection does not apply and a link like this should not be discovered.

<link rel="alternate stylesheet" type="application/atom+xml" href="/feed1" title="alternate stylesheet">

For further explanation, see
http://listserver.dreamhost.com/pipermail/whatwg-whatwg.org/2006-November/008054.html

This is also related to bug 362156.

Reproducible: Always

Steps to Reproduce:
1. Create a page with <link rel="alternate stylesheet" type="application/atom+xml" href="/feed1" title="alternate stylesheet">
2. Load it up and see if autodiscovery finds it.

(I tested this with the latest trunk as well)
Actual Results:  
The feed is discovered.

Expected Results:  
It shouldn't be.
Comment 1 Lachlan Hunt 2006-11-29 22:02:36 PST
Created attachment 247042 [details]
Test case
Comment 2 Robert Sayre 2006-12-05 10:11:33 PST
Created attachment 247558 [details] [diff] [review]
check for a stylesheet rel

I think this is fine for now, but instead of regexs, we should probably split(" ") the rel value into hash keys if we ever get around to combining the onLinkAdded handlers.
Comment 3 Robert Sayre 2006-12-05 10:18:28 PST
Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.743; previous revision: 1.742
done

Note You need to log in before you can comment on or make changes to this bug.