362349 - suppressMsgDisplay should only force display when exactly one message is selected

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Bruno 'Aqualon' Escherl]

At the moment switching suppressMsgDisplay from true to false loads the first selected message, even if multiple messages are selected. This prevents correct behaviour of enabling the Message Pane (found during work for bug 352696).

Patch to come.

Comment 1

[Bruno 'Aqualon' Escherl]

Attachment: forceDisplay only for exactly one selected message

With this patch unhiding the Message Pane only loads a message if numSelected is 1. This is the same behaviour as marking multiple messages in SeaMonkey (no message gets loaded).

I also trimmed the (mSuppressMsgDisplay && (mSuppressMsgDisplay != aSuppressDisplay)) if-clause, cause that's only true when mSuppressMsgDisplay is true and aSuppressDisplay is false, so querying !aSuppressDisplay instead of mSuppressMsgDisplay != aSuppressDisplay is enough.

David, can you please have a closer look if this breaks anything in Thunderbird since this is shared code?

Comment 2

[Bruno 'Aqualon' Escherl]

Comment on attachment 247056 [details] [diff] [review]
forceDisplay only for exactly one selected message

forceDisplay of course...

Comment 3

[Karsten Düsterloh]

Landed on trunk.