Build system does not honor --disable-printing

RESOLVED FIXED in Thunderbird 3.3a1

Status

Thunderbird
Build Config
RESOLVED FIXED
11 years ago
7 years ago

People

(Reporter: Mumia W., Assigned: Jory A. Pratt)

Tracking

Trunk
Thunderbird 3.3a1
x86
All
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird3.1 .3-fixed)

Details

Attachments

(3 attachments, 5 obsolete attachments)

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 Mnenhy/0.7.4.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 Mnenhy/0.7.4.0

The Mozilla build system for building Thunderbird (trunk)
does not honor this ./configure option: --disable-printing .

The make fails with this output:
> nsMessenger.cpp:86:32: nsIWebBrowserPrint.h: No such file or directory
> In file included from nsMessenger.cpp:133:
> nsMsgPrintEngine.h:53:32: nsIWebBrowserPrint.h: No such file or directory
> nsMsgPrintEngine.h:60:30: nsIPrintProgress.h: No such file or directory
> nsMsgPrintEngine.h:61:36: nsIPrintProgressParams.h: No such file or directory
> nsMsgPrintEngine.h:62:38: nsIPrintingPromptService.h: No such file or directory

Most probably there are many other places in the code where the --disable-priting option isn't recognized also.



Reproducible: Always

Steps to Reproduce:
1. Install Thunderbird trunk from CVS.
2. Configure it with the --disable-printing option to ./configure
3. Compile Thunderbird using "make" (GNU make).

Actual Results:  
nsMessenger.cpp:86:32: nsIWebBrowserPrint.h: No such file or directory
In file included from nsMessenger.cpp:133:
nsMsgPrintEngine.h:53:32: nsIWebBrowserPrint.h: No such file or directory
nsMsgPrintEngine.h:60:30: nsIPrintProgress.h: No such file or directory
nsMsgPrintEngine.h:61:36: nsIPrintProgressParams.h: No such file or directory
nsMsgPrintEngine.h:62:38: nsIPrintingPromptService.h: No such file or directory
In file included from nsMessenger.cpp:133:
nsMsgPrintEngine.h:119: error: `nsIPrintingPromptService' was not declared in
   this scope
nsMsgPrintEngine.h:119: error: template argument 1 is invalid
nsMsgPrintEngine.h:119: error: ISO C++ forbids declaration of `
   mPrintPromptService' with no type
nsMsgPrintEngine.h:121: error: `nsIPrintProgress' was not declared in this
   scope
nsMsgPrintEngine.h:121: error: template argument 1 is invalid
nsMsgPrintEngine.h:121: error: ISO C++ forbids declaration of `mPrintProgress'
   with no type
nsMsgPrintEngine.h:122: error: `nsIPrintProgressParams' was not declared in
   this scope
nsMsgPrintEngine.h:122: error: template argument 1 is invalid
nsMsgPrintEngine.h:122: error: ISO C++ forbids declaration of `
   mPrintProgressParams' with no type


Expected Results:  
I expected Thunderbird to be built without printing support.

Comment 1

11 years ago
let's just drop --disable-printing

Comment 2

11 years ago
If you're ok with that from a small-device embedding perspective, I'm all for it!
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Comment 3

11 years ago
Supporting --disable-printing would allow people to remove a
significant amount of bulk from their builds of Thunderbird.

And naturally, in a "small-device embedded" environment, the
printing code is a gratuitous waste of space.

The --disable-printing option is a good idea.
QA Contact: build → build-config
Created attachment 312388 [details] [diff] [review]
respects the --disable-printing flag for gtk2

as noted in previous comments, this helps for mobile where we're missing certain headers
Attachment #312388 - Flags: review?(benjamin)

Comment 5

10 years ago
Comment on attachment 312388 [details] [diff] [review]
respects the --disable-printing flag for gtk2

I need this to be a unified diff... it's really hard to see what has changed here.
Attachment #312388 - Flags: review?(benjamin) → review-
Created attachment 313083 [details] [diff] [review]
unified version of patch
[Checkin: Comment 10]
Attachment #312388 - Attachment is obsolete: true
Attachment #313083 - Flags: review?

Comment 7

10 years ago
Brad: you need to set the review flag like before.
Assignee: mscott → blassey
Attachment #313083 - Flags: review? → review?(benjamin)

Updated

10 years ago
Attachment #313083 - Flags: review?(benjamin) → review?(roc)
Attachment #313083 - Flags: superreview+
Attachment #313083 - Flags: review?(roc)
Attachment #313083 - Flags: review+
Brad: anything happening with this? Was the reviewed patch checked in?

IMHO this looks like it should be a core/build config bug now as its obviously not just Thunderbird that's affected.

Comment 9

9 years ago
I verify that the situation is similar when building firefox 3. Even when I build with --disable printing, the gtk+-unix-print-2.0 headers and libraries are still needed and the build fails because they are not available in my system. 

Perhaps this bug should also refer to firefox, not only thunderbird?
Comment on attachment 313083 [details] [diff] [review]
unified version of patch
[Checkin: Comment 10]

http://hg.mozilla.org/mozilla-central/index.cgi/log?rev=9ec74af08980
Attachment #313083 - Attachment description: unified version of patch → unified version of patch [Checkin: Comment 10]
On my Windows 2000,

Firefox 3.1a2pre builds fine.

But SeaMonkey v2.0a1pre does not:
{{
.../mailnews/base/src/nsMessenger.cpp(83) : fatal error C1083: Cannot open include file: 'nsIWebBrowserPrint.h': No such file or directory
}}

***

Brad, could you port your GTK2 patch to the other platforms ?
OS: Linux → All
Version: unspecified → Trunk
Blocks: 448369
(Assignee)

Comment 12

7 years ago
This is still very much a problem in tb-3.1.1.

nsMessenger.cpp:82:32: fatal error: nsIWebBrowserPrint.h: No such file or directory
compilation terminated.
(Assignee)

Comment 13

7 years ago
Created attachment 462304 [details] [diff] [review]
initial start on fixing the build code

This is just a start, there is much more that will needed to be completed before we will have a working build.
(Assignee)

Comment 14

7 years ago
Created attachment 462312 [details] [diff] [review]
Fully fix --disable-printing in tb

This has been fully tested with both --disable-printing and --enable-printing. I have been unable to find any regressions using it.
Attachment #462304 - Attachment is obsolete: true
Attachment #462312 - Flags: review?(dmose)
Attachment #462312 - Flags: review?(dmose) → review?(bugzilla)
(Assignee)

Updated

7 years ago
Duplicate of this bug: 482312
(Assignee)

Updated

7 years ago
Duplicate of this bug: 584046
(Assignee)

Comment 17

7 years ago
Created attachment 462662 [details] [diff] [review]
fix missed printing in mailnews/base/build/nsMsgFactory.cpp
Assignee: blassey.bugs → anarchy
Attachment #462312 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #462662 - Flags: review?
Attachment #462312 - Flags: review?(bugzilla)
(Assignee)

Updated

7 years ago
Attachment #462662 - Flags: review? → review?(bugzilla)

Comment 18

7 years ago
I think attachment 462613 [details] [diff] [review] should be the same as this patch here, if not, it would be nice to integrate the very few differences and get all this resolved at once, as the duping suggests.

Updated

7 years ago
Duplicate of this bug: 482312
(Assignee)

Comment 20

7 years ago
Created attachment 467248 [details] [diff] [review]
intergrate all changes that Robert had made as well.

Robert if you could double check to ensure that I did not overlook any of your changes as well would be appreciated.
Attachment #462662 - Attachment is obsolete: true
Attachment #467248 - Flags: review?(bugzilla)
Attachment #462662 - Flags: review?(bugzilla)
Attachment #467248 - Flags: feedback?(kairo)

Updated

7 years ago
Attachment #467248 - Flags: feedback?(kairo) → feedback+
Comment on attachment 467248 [details] [diff] [review]
intergrate all changes that Robert had made as well.

r=Standard8

Note: If you want this to get into 1.9.2 then we'll need a 1.9.2 version of this patch - I think the one you obsoleted would actually do most of that.
Attachment #467248 - Flags: review?(bugzilla) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/0eb496737b06
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
(Assignee)

Comment 23

7 years ago
(In reply to comment #21)
> Comment on attachment 467248 [details] [diff] [review]
> intergrate all changes that Robert had made as well.
> 
> r=Standard8
> 
> Note: If you want this to get into 1.9.2 then we'll need a 1.9.2 version of
> this patch - I think the one you obsoleted would actually do most of that.

I actually have the comm-1.9.2 branch patch, just need to recheck the work before I post it for you, I actually did miss a few sections that needed to be ifdef'd.
(Assignee)

Comment 24

7 years ago
Created attachment 467597 [details] [diff] [review]
comm-1.9.2-disable-printing

Mark hope you can get this landed before next release.
Attachment #467597 - Flags: review?(bugzilla)
(Assignee)

Comment 25

7 years ago
Reopening until we get it fixed on comm-1.9.2
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 26

7 years ago
Created attachment 467599 [details] [diff] [review]
comm-1.9.2-disable-printing

Sorry included in patch was the revert of another bug. Which I will post to the correct bug.
Attachment #467597 - Attachment is obsolete: true
Attachment #467599 - Flags: review?(bugzilla)
Attachment #467597 - Flags: review?(bugzilla)
(In reply to comment #25)
> Reopening until we get it fixed on comm-1.9.2

Jory: Our standard practice is to mark fixed once a bug is fixed on trunk. Branches are controlled by flags, see here for more info:

https://wiki.mozilla.org/Thunderbird/Landing_Patches_on_Thunderbird3.1
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
Attachment #467599 - Flags: review?(bugzilla)
Attachment #467599 - Flags: review+
Attachment #467599 - Flags: approval-thunderbird3.1.3+
Checked into 1.9.2 branch:

http://hg.mozilla.org/releases/comm-1.9.2/rev/07af9eb570c3
status-thunderbird3.1: --- → .3-fixed
You need to log in before you can comment on or make changes to this bug.