Add Support For Editing Tags

RESOLVED FIXED in Thunderbird2.0

Status

RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: mscott, Assigned: mscott)

Tracking

({verified1.8.1.3})

Thunderbird2.0
x86
Windows XP
verified1.8.1.3
Bug Flags:
blocking-thunderbird2 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

12 years ago
When we implemented the pref UI for managing your tags, we didn't get around to implementing the ability to Edit Tags. 

You should be able to change the name and the color of a tag.
(Assignee)

Comment 1

12 years ago
Seamonkey is under a string freeze on the branch so they may not be able to benefit from this patch on the branch.
Status: NEW → ASSIGNED
Flags: blocking-thunderbird2+
(Assignee)

Comment 2

12 years ago
Created attachment 247236 [details] [diff] [review]
the fix

1) If you pass in a tag key as an argument into the new tag dialog, we'll turn the dialog into an edit dialog.

2) If you try to change the name of a tag to a name of a tag that already exists, you get prompted with an alert.

3) I changed the behavior of nsMsgTagService::GetKeyForTag to not throw an error when a key doesn't exist for a tag name. This made the front end code that actually uses this routine easier since we don't have to wrap things in try/catch clauses when calling getKeyForTag.
(Assignee)

Comment 3

12 years ago
Comment on attachment 247236 [details] [diff] [review]
the fix

Neil or Karsten, do you mind reviewing the mailnews change to newTagDialog.js?

For seamonkey to leverage this on the trunk, we just need to pass in the key for the tag being edited as a window argument (along with the string change to messenger.properties)
Attachment #247236 - Flags: review?(neil)

Comment 4

12 years ago
> Neil or Karsten, do you mind reviewing the mailnews change to newTagDialog.js?

Since bug 342560 is fixed on trunk and branch, SeaMonkey does not use newTagDialog.js/xul anymore. :)

Comment 5

12 years ago
Comment on attachment 247236 [details] [diff] [review]
the fix

I don't think we use this dialog any more.
Attachment #247236 - Flags: review?(neil)
(Assignee)

Comment 6

12 years ago
I was just noticing the seamonkey edit tags preferences UI. Very nice!
(Assignee)

Comment 7

12 years ago
Comment on attachment 247236 [details] [diff] [review]
the fix

David, see comment 2 for details.
Attachment #247236 - Flags: superreview?(bienvenu)

Updated

12 years ago
Attachment #247236 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Updated

12 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird2.0

Comment 8

12 years ago
Created attachment 247265 [details] [diff] [review]
As per comment #2 part 3)
Attachment #247265 - Flags: review?(mnyromyr)

Comment 9

12 years ago
(In reply to comment #6)
> I was just noticing the seamonkey edit tags preferences UI. Very nice!

Scott, do you plan to add the equivalent of SM's Raise/Lower Importance for TB?
I can verify your current patch works, but I didn't know if this was actually complete.

Nit: I would have used "Precedence" rather than "Importance."

Updated

12 years ago
Attachment #247265 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 10

12 years ago
Created attachment 247636 [details] [diff] [review]
forgot to checkin this change

I just noticed this diff sitting in my tree that I forgot to check in when I landed  edit tag functionality. This is going to really suck because it means you can't add a new tag in beta 1 :(

Comment 11

12 years ago
I just successfully tested changing the text and color of a tag with TB 2 B2 (20070116), thank you very much!

But I recognized that the change is not applied to the current view immediately.

1) I sorted the tag column and changed just the tag which was now displayed for all the first mails.
2) The change was only visible after actively changing the view, i.e. by scrolling or resorting.

Comment 12

12 years ago
You mean it doesn't resort immediately on adding the tag?  That's intended.
See bug 119162.

Comment 13

12 years ago
Resorting or removing the current message because of an activated filter after the  label change was not my intention.

I was just wondering why the already displayed mails with the old label does not get updated with the new label (text and color).

Comment 14

12 years ago
> I was just wondering why the already displayed mails with the old label does
> not get updated with the new label (text and color).

The tag list shows the tags TB should know about. All other tags on messages are ignored. Changing a tag in the prefs just tells TB to forget about that tag, it does not change any tag on any message - the old tag will still be there, just hidden. 

Comment 15

12 years ago
I just can tell what I saw ;)

1) Sort the current view to show many messages containing one existing tag.
2) Open prefs and change the name and/or color of that particular tag.
3) Current view is not updated until another action has been occured (scrolling, sorting, etc.).
4) All mails previously contained the changed tag are showing the new tag now.

Comment 16

12 years ago
Any chance of providing tag reordering/renumbering in the tag preferences interface? In the current system, there's no method other than deletion for moving tags off the number keys after I've added them. I'm using tagging for projects and other concerns, but some tags will be less important over time (I'll still want to read/search on them, but much less likely to add them). For this reason, the ability to reorder tags would make the whole tag feature much more useful.

Comment 17

12 years ago
Yoz, I've just opened bug 369114 for that feature.
verified for 1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620 (Thunderbird 2 RC1) - Editing Tags works fine
Keywords: fixed1.8.1.1 → verified1.8.1.3
You need to log in before you can comment on or make changes to this bug.