Closed
Bug 362577
Opened 18 years ago
Closed 4 months ago
coreconf should not define the _DEBUG macro.
Categories
(NSS :: Build, defect, P5)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wtc, Unassigned)
References
()
Details
coreconf has been defining the _DEBUG macro in debug builds since day one. It turns out that this macro should only be defined by the compiler on Windows -- this macro means the debug C runtime library is being used. See http://msdn2.microsoft.com/en-us/library/0b98s6w8(VS.80).aspx Run-Time Library Reference _DEBUG The compiler defines _DEBUG when you specify the /MTd or /MDd option. These options specify debug versions of the C run-time library. So in the normal debug build (USE_DEBUG_RTL is not set), we should not define _DEBUG, and in the USE_DEBUG_RTL=1 debug build, we should simply let the compiler define this macro.
Reporter | ||
Comment 1•18 years ago
|
||
We also need to fix the code that tests the _DEBUG macro. We can search for "defined(_DEBUG)" and "def _DEBUG" in the source tree: http://lxr.mozilla.org/security/search?string=defined%28_DEBUG%29 http://lxr.mozilla.org/security/search?string=def+_DEBUG The second query found that all of our Windows resource scripts (*.rc) contain #ifdef _DEBUG, which should be changed to #ifdef DEBUG.
Comment 2•18 years ago
|
||
nsprpub also tests for #ifdef _DEBUG. See <http://landfill.mozilla.org/mxr-test/security/search?string=def%5B%5EA-Za-z0-9%5D*_DEBUG®exp=on&case=on&find=&findi=&filter=&tree=security>
Updated•2 years ago
|
Severity: normal → S3
Comment 3•1 year ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Assignee: wtc → nobody
Updated•4 months ago
|
Severity: S3 → S4
Status: NEW → RESOLVED
Closed: 4 months ago
Priority: -- → P5
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•