362578 - View - Toolbars fails silently in Cocoafox

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Phil Ringnalda (:philor)]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a1) Gecko/20061201 Firefox/3.0a1 ID:2006120118

STR:

In Firefox, click View menu, hover Toolbars submenu item, click either "Navigation Toolbar" or "Bookmarks Toolbar."

Expected: toolbar disappears if it's present, or appears if it's hidden.

Actual: nothing in the error console, nothing in the console in a debug build, just... nothing happens.

Works perfectly in an --enable-default-toolkit=mac build from the same tree.

Comment 1

[Josh Aas]

I traced native events through our cocoa menu/menuitem code and I don't see any problems. It looks like the problem probably exists once the DOM event is sent into content.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

*** Bug 363158 has been marked as a duplicate of this bug. ***

Comment 3

[Asaf Romano (gone)]

Attachment: patch

copied over from the carbon version.

Comment 4

[Phil Ringnalda (:philor)]

*** Bug 364193 has been marked as a duplicate of this bug. ***

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 248014 [details] [diff] [review]
patch

sr=pink

Comment 6

[Asaf Romano (gone)]

Checking in widget/src/cocoa/nsMenuItemX.mm;
/cvsroot/mozilla/widget/src/cocoa/nsMenuItemX.mm,v  <--  nsMenuItemX.mm
new revision: 1.21; previous revision: 1.20
done