362639 - Lightning main menu has no accesskey

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[Cédric Corazza]

There is no accesskey for the "Calendar" menu in Lightning.

Patch follows

Comment 1

[Cédric Corazza]

Attachment: Patch adding accesskeys to "Calendar" menu

This patch also adds a missing accesskey in Sunbird for "View > Number of weeks"

Comment 2

[Matthew (lilmatt) Willis]

Comment on attachment 247328 [details] [diff] [review]
Patch adding accesskeys to "Calendar" menu

>Index: lightning/content/messenger-overlay-toolbar.xul
>===================================================================
>         <menuitem id="ltnChangeViewMonth" 
>                   label="&lightning.toolbar.monthview.label;" 
>+                  accesskey="&lightning.toolbar.monthview.accesskey;"
>                   oncommand="showCalendarView('month')"/>
>         <menuseparator/>
>-         <menu label="&viewMenu.label;">
>+         <menu label="&viewMenu.label;" accesskey="&viewMenu.accesskey;">
Let's not preserve the indenting error when we replace this line ^^. Bump it to the left one space so it aligns with menuseparator. However, leave the rest below where it is.

>             <menupopup>
>                <menuitem type="checkbox"
>                          id="ltn-workdays-only"
>                          persist="checked"
>                          label="&calendar.onlyworkday.checkbox.label;"
>+                         accesskey="&calendar.onlyworkday.checkbox.accesskey;"
>                          oncommand="toggleWorkdaysOnly()"/>
>                <menuitem type="checkbox"
>                          id="ltn-tasks-in-view"
>                          persist="checked"
>                          label="&calendar.displaytodos.checkbox.label;"
>+                         accesskey="&calendar.displaytodos.checkbox.accesskey;"
>                          oncommand="toggleTasksInView()"/>
>            </menupopup>
>         </menu>
>         <menuitem id="ltnGoToToday" 
>                   label="&calendar.context.gototoday.label;" 
>+                  accesskey="&calendar.context.gototoday.accesskey;"
>                   oncommand="goToToday()"/>
>         <menuseparator/>
>         <menuitem id="calendar-import-menu"



> This patch also adds a missing accesskey in Sunbird for "View > Number of weeks"

Don't combine unlike stuff into one bug and one patch.  While it may seem silly and takes more time, doing so makes CVS blame and checkin comments make more sense, makes patches smaller and easier to review (and therefore faster to get reviewed and checked in).

>Index: sunbird/base/content/calendar-menubar.inc

Pull this out to another bug.


r=lilmatt with those changes

Comment 3

[Cédric Corazza]

Attachment: Patch with changes asked by lilmatt

This patch addresses the changes asked by lilmat.
I will open a new bug for the missing Sunbird accesskey.

Comment 4

[Joey Minta]

Comment on attachment 247437 [details] [diff] [review]
Patch with changes asked by lilmatt

Excellent.

Comment 5

[Matthew (lilmatt) Willis]

Patch checked in on MOZILLA_1_8_BRANCH and trunk

-> FIXED