362646 - domNodeDialog.xul doesn't have control attributes pointing to valid ids

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Shawn Wilsher :sdwilsh]

In domNodeDialog we don't have the right ids for the control attributes, so they don't actually work.

 57         <label value="&nodeName.label;" control="nodeName"/>
 58         <textbox id="tx_nodeName" oninput="dialog.toggleAccept();"/>
The control should be "tx_nodeName".

Comment 1

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

simple fix

Comment 2

[[e-mail]]

Comment on attachment 248015 [details] [diff] [review]
v1.0

>? extensions/inspector/.git
Been playing with alternative source code control systems? ;-)

>? extensions/inspector/resources/content/viewers/domNode/.domNodeDialog.xul.swp
I hope you saved before you diffed :-P

Comment 3

[Shawn Wilsher :sdwilsh]

(In reply to comment #2)
> (From update of attachment 248015 [details] [diff] [review] [edit])
> >? extensions/inspector/.git
> Been playing with alternative source code control systems? ;-)
> 
> >? extensions/inspector/resources/content/viewers/domNode/.domNodeDialog.xul.swp
> I hope you saved before you diffed :-P

I swear I deleted those two lines and saved the diff file before submitting...

Comment 4

[Daniel Brooks [:db48x]]

Comment on attachment 248015 [details] [diff] [review]
v1.0

yea, looks good. r=db48x

Comment 5

[Shawn Wilsher :sdwilsh]

Attachment: v1.0.1

r=db48x, sr=neil

Just cleaned up those first two lines that shouldn't have been there.

Comment 6

[:Gijs (he/him)]

Checking in mozilla/extensions/inspector/resources/content/viewers/domNode/domNodeDialog.xul;
/cvsroot/mozilla/extensions/inspector/resources/content/viewers/domNode/domNodeDialog.xul,v <--  domNodeDialog.xul
new revision: 1.2; previous revision: 1.1
done