362754 - confirmPhishingUrl entity is not logically formulated

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Hendrik Maryns]

The entity confirmPhishingUrl in messenger.properties talks about a message and at the same time about a website.  It should be more consistent.

Proposal: 

confirmPhishingUrl=%1$S thinks this message is a scam. The links on it may be trying to impersonate web pages you want to visit. Are you sure you want to visit %2$S?

Comment 1

[Scott MacGregor]

I like the new suggested string. 

This is just improving the english translation and is not changing the meaning so we should be able to take this on the branch even though it's after the string freeze.

Comment 2

[Scott MacGregor]

What about:

confirmPhishingUrl=%1$S thinks this message is a scam. The link may be trying to impersonate the web page you want to visit.  Are you sure you want to visit %2$S?

or

confirmPhishingUrl=%1$S thinks this message is a scam. The links in the message may be
trying to impersonate web pages you want to visit. Are you sure you want to
visit %2$S?

Comment 3

[Hendrik Maryns]

(In reply to comment #2)
> What about:
> 
> confirmPhishingUrl=%1$S thinks this message is a scam. The link may be trying
> to impersonate the web page you want to visit.  Are you sure you want to visit
> %2$S?
> 
> or
> 
> confirmPhishingUrl=%1$S thinks this message is a scam. The links in the message
> may be
> trying to impersonate web pages you want to visit. Are you sure you want to
> visit %2$S?

I’d prefer the second, since most of the times those scams contain more than one link.  OTOH, mostly only one of those links is a phish.

Comment 4

[Scott MacGregor]

Attachment: improve the en-US translation

Option #2 it is.

Improves the translation of the confirm phishing string. Not changing the meaning, so this can land after the string freeze.