Bad accesskey in "Find" dialog

VERIFIED FIXED

Status

Mozilla Localizations
ru / Russian
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: Alexander L. Slovesnik, Assigned: Alexander L. Slovesnik)

Tracking

({fixed1.8.1.2, verified1.8.1.2})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
Accesskeys for "Next" and "Match case" are same. Screenshot is attached.
(Assignee)

Comment 1

11 years ago
Created attachment 247470 [details]
Screenshot of "Find" dialog.
(Assignee)

Comment 2

11 years ago
Created attachment 250490 [details] [diff] [review]
Patch

Proposed patch
Attachment #250490 - Flags: approval1.8.1.2?
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED

Comment 3

11 years ago
Comment on attachment 250490 [details] [diff] [review]
Patch

[ru] approval denied.

r- on this patch, you changed both accesskeys from C to p, now they're duplicates again.
Attachment #250490 - Flags: review-
Attachment #250490 - Flags: approval1.8.1.2?
Attachment #250490 - Flags: approval1.8.1.2-
Axel, the conflict was between next.accesskey and caseSensitiveCheckbox.accesskey, Alexander only changed the second one - in two files - findbar.dtd and finddialog.dtd.

<!ENTITY next.accesskey "С">
...
<!ENTITY caseSensitiveCheckbox.accesskey "С">

There's nothing wrong with this patch. 

Comment 5

11 years ago
Comment on attachment 250490 [details] [diff] [review]
Patch

[ru] accesskey fix approved for 1.8.1.2. Code freeze is Thursday 1/18, please use fixed1.8.1.2 and verified1.8.1.2 as always.

Sorry for the confusion on the patch, and thanks to marcoos for catching that.
Attachment #250490 - Flags: review-
Attachment #250490 - Flags: approval1.8.1.2-
Attachment #250490 - Flags: approval1.8.1.2+
(Assignee)

Comment 6

11 years ago
checked-in on 1.8 branch:

Checking in findbar.dtd;
/l10n/l10n/ru/toolkit/chrome/global/findbar.dtd,v  <--  findbar.dtd
new revision: 1.6.2.6; previous revision: 1.6.2.5
done
Checking in finddialog.dtd;
/l10n/l10n/ru/toolkit/chrome/global/finddialog.dtd,v  <--  finddialog.dtd
new revision: 1.2.2.1; previous revision: 1.2
done

Thanks for help, Marcoos.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.2
Resolution: --- → FIXED
(Assignee)

Comment 7

11 years ago
Verified on Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.8.1.2pre) Gecko/20070106 BonEcho/2.0.0.2pre
Status: RESOLVED → VERIFIED
Keywords: verified1.8.1.2
You need to log in before you can comment on or make changes to this bug.