362764 - Bad accesskey in "Find" dialog

Status: VERIFIED FIXED

(Mozilla Localizations :: ru / Russian, defect)

Description

[Alexander L. Slovesnik]

Accesskeys for "Next" and "Match case" are same. Screenshot is attached.

Comment 1

[Alexander L. Slovesnik]

Attachment: Screenshot of "Find" dialog.

Comment 2

[Alexander L. Slovesnik]

Attachment: Patch

Proposed patch

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 250490 [details] [diff] [review]
Patch

[ru] approval denied.

r- on this patch, you changed both accesskeys from C to p, now they're duplicates again.

Comment 4

[Marek Stępień [:marcoos, inactive]]

Axel, the conflict was between next.accesskey and caseSensitiveCheckbox.accesskey, Alexander only changed the second one - in two files - findbar.dtd and finddialog.dtd.

<!ENTITY next.accesskey "С">
...
<!ENTITY caseSensitiveCheckbox.accesskey "С">

There's nothing wrong with this patch. 

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 250490 [details] [diff] [review]
Patch

[ru] accesskey fix approved for 1.8.1.2. Code freeze is Thursday 1/18, please use fixed1.8.1.2 and verified1.8.1.2 as always.

Sorry for the confusion on the patch, and thanks to marcoos for catching that.

Comment 6

[Alexander L. Slovesnik]

checked-in on 1.8 branch:

Checking in findbar.dtd;
/l10n/l10n/ru/toolkit/chrome/global/findbar.dtd,v  <--  findbar.dtd
new revision: 1.6.2.6; previous revision: 1.6.2.5
done
Checking in finddialog.dtd;
/l10n/l10n/ru/toolkit/chrome/global/finddialog.dtd,v  <--  finddialog.dtd
new revision: 1.2.2.1; previous revision: 1.2
done

Thanks for help, Marcoos.

Comment 7

[Alexander L. Slovesnik]

Verified on Mozilla/5.0 (X11; U; Linux i686; ru; rv:1.8.1.2pre) Gecko/20070106 BonEcho/2.0.0.2pre