If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Pinstripe] Disabled default buttons should never be blue

RESOLVED FIXED

Status

()

Core
Widget: Cocoa
--
minor
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Håkan Waara, Assigned: Håkan Waara)

Tracking

({polish})

Trunk
x86
Mac OS X
polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

11 years ago
When a button is mapped to return, it is made blue in Aqua. However, a disabled button cannot be blue. I tested this in Interface Builder.

See the screenshot, where I happened upon such an instance in our UI, somewhere in the prefs land.
(Assignee)

Comment 1

11 years ago
Created attachment 247527 [details]
A disabled blue button ... just looks weird

I think this is from the Cookie exceptions prefpane.
(Assignee)

Comment 2

11 years ago
It happens in trunk, not in Firefox 2, so regression.

To reproduce:

Go to Preferences > Security, and click the topmost "Exceptions..." button. The resulting dialog has a disabled default button.

Comment 3

11 years ago
Hmm, something in the native theme implementation that has regressed?
(Assignee)

Comment 4

11 years ago
Oh, might be a cairo native theme regression, yeah.
Assignee: nobody → joshmoz
Component: Themes → Widget: Cocoa
QA Contact: themes → cocoa
(Assignee)

Comment 5

11 years ago
Created attachment 247533 [details]
Testcase
(Assignee)

Comment 6

11 years ago
Created attachment 247534 [details] [diff] [review]
Fix

Simple fix
Assignee: joshmoz → hwaara
Status: NEW → ASSIGNED
Attachment #247534 - Flags: review?(joshmoz)

Comment 7

11 years ago
Hmm, the testcase works for me with the 061205 trunk build (10.3.9).
(Assignee)

Comment 8

11 years ago
(In reply to comment #7)
> Hmm, the testcase works for me with the 061205 trunk build (10.3.9).

Doesn't work for me in the 20061204 build, 10.4.8... Perhaps it's 10.4-specific, though I wouldn't think so.

Updated

11 years ago
Attachment #247534 - Flags: review?(joshmoz) → review+
(Assignee)

Updated

11 years ago
Attachment #247534 - Flags: superreview?(pavlov)
*** Bug 363226 has been marked as a duplicate of this bug. ***

Updated

11 years ago
Attachment #247534 - Flags: superreview?(pavlov) → superreview+
(Assignee)

Comment 10

11 years ago
Checked in to trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.