Closed
Bug 362913
Opened 19 years ago
Closed 19 years ago
Undo tab close keeps 3 least recently closed tabs
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a1
People
(Reporter: ajschult784, Assigned: csthomas)
References
Details
Attachments
(1 file)
|
1.19 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
With linux seamonkey build 2006-12-05-11-trunk, the recently closed tabs menu item contains the first 3 tabs I closed for the window. The items are never replaced with more recently closed tabs unless I actually undo close one of them to make room for a new third.
|
Assignee | |
Comment 1•19 years ago
|
||
Please file bugs in the right product so I can find them later.
Browsers are expired with shift, and added with unshift. There is no caching of the list for the file menu, so I don't understand why you'd see this behavior.
Component: Tabbed Browser → XP Apps: GUI Features
Product: Core → Mozilla Application Suite
Target Milestone: --- → seamonkey1.5alpha
|
|
Assignee | |
Comment 2•19 years ago
|
||
Shouldn't http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/bindings/tabbrowser.xml#1294 be using pop instead of shift? Did I regress this at some point? I would have thought we would have caught this a long time ago if it was in the original patch.
|
|
Assignee | |
Comment 3•19 years ago
|
||
In bug 354953 I changed around some shift/unshift/push/pop stuff, but missed a case.
Blocks: 354953
|
|
Assignee | |
Comment 4•19 years ago
|
||
I can't test this right now.
Attachment #247682 -
Flags: review?(neil)
|
||
Comment 5•19 years ago
|
||
Comment on attachment 247682 [details] [diff] [review]
untested patch
r+sr=me (tested).
Attachment #247682 -
Flags: review?(neil) → review+
|
|
Assignee | |
Comment 6•19 years ago
|
||
Checked in
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•