362918 - Installer should check the free space for the unc path

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[a.hendriks]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)
Build Identifier: http://download.mozilla.org/?product=sunbird-0.3&os=win&lang=en-US

I'm trying to install to a network share: \\marge\programs\sunbird
The installer reports "You don't have sufficient disk space to install to this location", although it specifies a requirement of "19.1MB" and an available space of "12.9GB". 

I have write access to the share I'm trying to install it to

Reproducible: Always

Steps to Reproduce:
1.Installing to that location reports the problem
Actual Results:  
Install to network location

Expected Results:  
Reported 'insufficient disk space'

At minimum, allow me to override its detection that insufficient space is available. But it should just install without complaining

Comment 1

[Stefan Sitter [:ssitter]]

Robert: Do you know this issue?

Comment 2

[Hermann Schwab]

Maybe the installer also needs write access to the /temp location?

Comment 3

[a.hendriks]

(In reply to comment #2)
> Maybe the installer also needs write access to the /temp location?

What /temp dir would that be ? C:\temp and %USERPROFILE%\local settings\temp are both writable. %TMP% and %TEMP% are set to C:\temp.

I manually moved the sunbird installation to its desired location, and all works fine. I reproduced the problem by installing int into \\marge\programs\test\sunbird (giving my user ownership of \\marge\programs\test)

An strace of the smb process on the server does not appear to show it accessing any test directory. If I 'net use P: \\marge\programs' the installer works fine to P:\test, so it is apparently has something to do with UNC paths (I was trying to avoid a mapping because keeping drive letters alive over on-demand-VPN is troublesome)

Comment 4

[Robert Strong (they/them - no direct email)]

I haven't verified this but it doesn't surprise me. The old installer prevented this by not allowing typing in the path. Getting the installer to check the freespace for the unc path would be the better way to fix this. Anyone want to take this bug?

http://lxr.mozilla.org/seamonkey/source/toolkit/mozapps/installer/windows/nsis/common.nsh#727

Comment 5

[Martin Schröder [:mschroeder]]

I think, Sunbird is the wrong component for this problem. Maybe it should be moved to Toolkit > NSIS Installer.

Comment 6

[Martin Schröder [:mschroeder]]

Moving to Toolkit > NSIS Installer (see comment#4).

Comment 7

[Robert Strong (they/them - no direct email)]

This will be fixed by the patch in bug 479361 after it lands so adding dependency

Comment 8

[Robert Strong (they/them - no direct email)]

Fixed by bug 479361

Comment 9

[Robert Strong (they/them - no direct email)]

Also fixed in mozilla-1.9.1 by bug 479361