- create a new event
- open the attendee dialog
- there are no borders visible between different days visible
- see http://wiki.mozilla.org/Calendar:SMB_Event_Dialog_-_Invite_Attendee
- there are borders between displayed days
*** Bug 411166 has been marked as a duplicate of this bug. ***
Oh, crap, sorry, moving back, send hatemail to this address.
Dialog is also present in Sunbird -> Move to Calendar:General
Richard, another one for you maybe?
Created attachment 626377 [details] [diff] [review]
All I can do is giving a border in the header to separate the days.
If a border is needed also below in the grid, then a JS function is needed to tag the last (or first) .freebusy-grid of a day to specially style this item with a border.
Created attachment 626378 [details]
patch in action
Can't you use the :first-child and :last-child pseudo-classes?
No, because the .freebusy-grid items are not grouped per day. The :first-child is the first in the row (totally on the left) and :last-child is the last on the right when you scroll to the right.
Comment on attachment 626377 [details] [diff] [review]
Something like this should give you the needed classes (please ignore it being on comm-central, that was accidental and has been backed out):
On your screenshot the vertical lines have at least 1px offset if you compare header day lines and body lines. I can't test this ATM due to build issues.
If you want to try it with the JS changes, then be my guest. If not, then just push the patch you have (with offset fixed) and leave this bug open.
(In reply to Philipp Kewisch [:Fallen] from comment #9)
> On your screenshot the vertical lines have at least 1px offset if you
> compare header day lines and body lines. I can't test this ATM due to build
I've fixed the line alignment locally.
No problem, the merge is far away. Let's check-in the patch in one piece.
> If you want to try it with the JS changes, then be my guest. If not, then
> just push the patch you have (with offset fixed) and leave this bug open.
I tried the JS change and it works partially:
- The first 'first-in-day' in the grid is on the second .freebusy-grid element. The
next days are okay.
- I've never seen a 'last-in-day' element.
- first-in-day and last-in-day should also have the freebusy-grid. Then only the
additional changes have to be added in CSS.
Created attachment 637886 [details] [diff] [review]
This patch was very nervewracking. I really need to overhaul the attendee dialog code at some point :-)
It should work now, both the grid and the time bar at the top have the first-in-day/last-in-day classes. Let me know if something doesn't work as expected.
Created attachment 638181 [details] [diff] [review]
Philipp, thank you for the JS fixes.
This patch inserts a 2px space between days in title and on the rows on top. The empty rows have no border to separate the days because they have no freebusy-grid items in them.
Created attachment 638182 [details]
patch in action
Screenshot with Attendees list patch on Windows, Linux and Mac.
Philipp, have you any time to review this patch?
And can this land also on beta or aurora?
Comment on attachment 638181 [details] [diff] [review]
r=philipp. I don't think we should take this down to beta, I'm not sure if there will be another beta before the release.
Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/0cce91ac3be6
and comm-aurora: http://hg.mozilla.org/releases/comm-aurora/rev/84a77b11c96b