[Pinstripe] Restrict popupmenus to a certain height

NEW
Unassigned

Status

()

12 years ago
10 years ago

People

(Reporter: hwaara, Unassigned)

Tracking

({polish})

Trunk
x86
Mac OS X
polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
In Aqua, you can't make popupmenus taller than the default height. If you try to in Interface Builder, then the clicking region will be taller, but the actual popup image won't (because it looks bad).

I'll post a screenshot to demonstrate.
(Reporter)

Comment 1

12 years ago
Created attachment 247809 [details]
Popupmenus should never be this tall

This is a screenshot from some XUL. Popupmenus shouldn't be able to be this tall.
(Reporter)

Comment 2

12 years ago
Created attachment 247810 [details]
A normal-sized popupmenu with the right height

Comment 3

12 years ago
Iirc the height is hardcoded. It would probably be best to not set any height at all and let the font-size determine the height instead.
(Reporter)

Comment 4

12 years ago
(In reply to comment #3)
> Iirc the height is hardcoded. It would probably be best to not set any height
> at all and let the font-size determine the height instead.

As long as it looks good, yeah... BTW, why is the default font in XUL documents the one in the screenshot, and not the system font?

Comment 5

12 years ago
(In reply to comment #4)
> (In reply to comment #3)
> > Iirc the height is hardcoded. It would probably be best to not set any height
> > at all and let the font-size determine the height instead.
> 
> As long as it looks good, yeah... BTW, why is the default font in XUL documents
> the one in the screenshot, and not the system font?
> 

The font that you see is the font you have specified in your browser settings. This is probably correct. This is also why it sometimes can be dangerous to hard-code sizes - imagine that a xul developer creates a menulist and the document that the menulist is in has a 7px font. The "menupopup" is then 20px high with a 7px font in and when you open the menulist, font-size in menuitems is Apple's menu font :-/

Updated

10 years ago
Assignee: joshmoz → nobody
You need to log in before you can comment on or make changes to this bug.