Need project patch to dispose of non-virtual dtor warnings in prefpane targets

VERIFIED WORKSFORME

Status

Camino Graveyard
General
--
minor
VERIFIED WORKSFORME
11 years ago
11 years ago

People

(Reporter: Chris Lawson (gone), Assigned: Smokey Ardisson (offline for a while; not following bugs - do not email))

Tracking

Details

(Reporter)

Description

11 years ago
I finally figured out how to get rid of them, so let's kill those little buggers.

Basically, I went through and added "-Wno-non-virtual-dtor" to the Build tab in all .mm files in each Preference Pane under the Targets section of the project. (You can select multiple .mm files at once to do that.)

Smokey, can you generate a project patch based on the above?

Mento, is that the right approach?

Comment 1

11 years ago
Is there a reason we wouldn't want to just add it to the target itself, rather than each file?
We turned that warning off globally before, in each build style, and when I look at each prefPane target, that setting is off.

Are you sure you're still seeing them?  If so, why aren't they inheriting that from the parent build styles?
I don't see these warnings in any of the tinderbox logs, either; --> WFM
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WORKSFORME
(Reporter)

Comment 4

11 years ago
Something along the line somewhere seems to have fixed this, yes. Verified. If it comes back and I can't get rid of it easily, I'll file a new bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.