Closed Bug 363102 Opened 19 years ago Closed 19 years ago

Tinderbox uses inconsistant sources to track the start and end times of a build

Categories

(Webtools Graveyard :: Tinderbox, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: justdave, Assigned: cls)

Details

Attachments

(1 file)

The start time of a build is taken from a log header in the mail submission, given by the client, generated using the clock on the client machine. The end time of a build is taken from the time the mail was processed (which is no longer necessarily the time the mail was received, thanks to the way mail is queued now). This is also a problem if the clocks on the client and the server aren't in sync with each other. We should make an attempt to use the same time source on both the start time and end time, whichever source that is (and it shouldn't be the processing time).
Attached patch v1.0Splinter Review
For backwards compatibility, I decided to keep the structure of build.dat the same but we'll start treating the first field as the build end time instead of the mail processed time. If the client doesn't send the 'buildenddate' header, then we fall back to the old behavior of treating the mail processing time as the end date.
Assignee: morgamic → cls
Status: NEW → ASSIGNED
Attachment #250982 - Flags: review?(bear)
Attachment #250982 - Flags: review?(bear) → review+
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: