Closed
Bug 363112
Opened 18 years ago
Closed 18 years ago
nsDeckFrame::GetSelectedBox should use mIndex
Categories
(Core :: Web Painting, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: WeirdAl, Assigned: WeirdAl)
References
Details
Attachments
(1 file)
|
2.36 KB,
patch
|
enndeakin
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Spun off of bug 363032 comment 5.
|
Assignee | |
Comment 1•18 years ago
|
||
I have a couple caveats about this patch.
(1) mIndex and what GetSelectedIndex() returns aren't guaranteed to be the same thing, I believe. I'm not sure what to do about that. (Do we want to guarantee it by NS_ASSERTION? Is this patch not right?)
(2) In nsDeckFrame::IndexChanged(), we have two nsIBox* pointers; we probably need only one.
Attachment #247890 -
Flags: review?(enndeakin)
|
|
Assignee | |
Comment 2•18 years ago
|
||
(In reply to comment #1)
> (1) mIndex and what GetSelectedIndex() returns aren't guaranteed to be the same
> thing, I believe. I'm not sure what to do about that. (Do we want to guarantee
> it by NS_ASSERTION? Is this patch not right?)
Duh, I need to read a little more context; IndexChanged() handles that case.
|
||
Updated•18 years ago
|
Attachment #247890 -
Flags: review?(enndeakin) → review+
|
|
Assignee | |
Updated•18 years ago
|
Attachment #247890 -
Flags: superreview?(neil)
|
||
Updated•18 years ago
|
Attachment #247890 -
Flags: superreview?(neil) → superreview+
|
|
Assignee | |
Comment 3•18 years ago
|
||
fix checked in by db48x; thanks to all.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: Layout: View Rendering → Layout: Web Painting
You need to log in
before you can comment on or make changes to this bug.
Description
•