If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

merge nsToolkit and nsToolkitBase in cocoa widgets

RESOLVED FIXED

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

13.75 KB, patch
Details | Diff | Splinter Review
(Assignee)

Description

11 years ago
Instead of moving nsToolkitBase into cocoa widgets, we should just merge it into nsToolkit.
(Assignee)

Comment 1

11 years ago
Created attachment 247889 [details] [diff] [review]
fix v1.0
Attachment #247889 - Flags: review?(mark)
(Assignee)

Comment 2

11 years ago
I acknowledge there there is more work we could do in the toolkit code, but I just want to get the merge done for now and deal with other issues separately.

Updated

11 years ago
Attachment #247889 - Flags: review?(mark) → review+
(Assignee)

Updated

11 years ago
Attachment #247889 - Flags: superreview?(mikepinkerton)
Comment on attachment 247889 [details] [diff] [review]
fix v1.0

rs=pink
Attachment #247889 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 4

11 years ago
Created attachment 247931 [details] [diff] [review]
fix v1.0.1

This is what I checked in. Includes a little more cleanup.
Attachment #247889 - Attachment is obsolete: true
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.