363166 - HAVE_ATOMIC_DWORD_ACCESS can't be set, yet we have #ifdef'd code

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Patrick Welche]

User-Agent:       Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.9a1) Gecko/20051031 Firefox/1.6a1
Build Identifier: Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.9a1) Gecko/20051031 Firefox/1.6a1

As far as I can tell, HAVE_ATOMIC_DWORD_ACCESS is not defined anywhere. There are no tests which set it, nor machine dependent header files which define it. I propose that the code #ifdef'd be garbage collected from the only file in which it appears: js/src/jsinterp.h

or should it be explained somewhere that one could define
JS_ATOMIC_DWORD_LOAD(pce, entry)
JS_ATOMIC_DWORD_STORE(pce, entry)
HAVE_ATOMIC_DWORD_ACCESS

but then is it a documentation bug?

(This is a minor niggle, I just saw this while looking for dwords)

Reproducible: Always

Comment 1

[Brendan Eich [:brendan]]

See bug 128150, which wants to define these or else no-op the property cache macros.  This bug is invalid as stated.  If the property cache can be done away with to avoid the whole problem of writing asm for atomic double-word loads and stores, that's a different bug (probably just a particular fix to 128150).

/be