363197 - Add NSS leak checking to tinderbox

Status: RESOLVED FIXED

(NSS :: Test, enhancement, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

It has been reported (bug 363184) that a recent NSS checkin has increased leakage, a serious regression.  The only way it was discovered was through
the Tinderbox for FireFox!

FireFox's tinderbox includes much more information than simple pass/fail
for the build and for a simple QA script.  See it at 
http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox&hours=24&maxdate=1165472224&legend=1

Among many other useful things, it shows 
   Lk:XXX (bytes leaked)
This allows developers to see the effect of a checkin on leaks, immediately
after it is first built.  

NSS's tinderbox should also have this feature.  ASAP.

Comment 1

[Slavomir Katuscak]

Attachment: Patch to print DBG/OPT version.

Tinderbox printing is already part of memleak script. This patch adds version info.

Comment 2

[Neil Williams]

Comment on attachment 265116 [details] [diff] [review]
Patch to print DBG/OPT version.

Looks like it does the trick. Why don't the leak stats report for all the tinderboxes? We don't run leak checking on all of them?

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 265116 [details] [diff] [review]
Patch to print DBG/OPT version.

Pls commit this on the trunk.  If it goes OK, then when the branch opens, you can commit on the branch.

Comment 4

[Slavomir Katuscak]

> Looks like it does the trick. Why don't the leak stats report for all the
> tinderboxes? We don't run leak checking on all of them?
> 

We have some Tinderboxes only for leak checking. It's because leak checking takes much more time than other tests.

Comment 5

[Slavomir Katuscak]

Trunk:

Checking in memleak.sh;
/cvsroot/mozilla/security/nss/tests/memleak/memleak.sh,v  <--  memleak.sh
new revision: 1.5; previous revision: 1.4

Comment 6

[Slavomir Katuscak]

Branch:

Checking in memleak.sh;
/cvsroot/mozilla/security/nss/tests/memleak/memleak.sh,v  <--  memleak.sh
new revision: 1.1.2.4; previous revision: 1.1.2.3
done