363285 - marquee broken

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Peter van der Woude [:Peter6]]

happened after reflow branch landing.
I'll work on simplified testcases based on linked page

Comment 1

[Peter van der Woude [:Peter6]]

Attachment: testcase

basically, the text scrolls its own length and than "stops" 
it restarts again when it has reached the end of the marquee box (this process isn't visable).

Comment 2

[Martijn Wargers (dead)]

See discussion at http://www.mail-archive.com/[e-mail]/msg00129.html
I probably am able to (and willing to) fix it with some js code, but I'm not really sure what the conclusion of that mail thread was.
It seems to indicate that there is something wrong in the reflow branch, so in that case it should be fixed in the layout code and not in the marquee xbl binding.

Comment 3

[Martijn Wargers (dead)]

Attachment: patch

Ok, this fixes the bug by reverting back to the use of -moz-box instead of table.
I guess this is now preferable again, because bug 307763 and bug 313750 are fixed by the reflow branch landing.
Also this patch would fix bug 313219, because the white-space rule can be removed.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 248185 [details] [diff] [review]
patch

Sure

Comment 5

[Boris Zbarsky [:bzbarsky]]

> but I'm not really sure what the conclusion of that mail thread was.

That it's a reflow branch regression and we should file a bug on it and fix it... ;)  Please cc me and dbaron on the bug.

I'd file it if the net connection here sucked just a tad less.  :(

Comment 6

[Martijn Wargers (dead)]

Checking in xbl-marquee.xml;
/cvsroot/mozilla/layout/style/xbl-marquee/xbl-marquee.xml,v  <--  xbl-marquee.xm
l
new revision: 1.24; previous revision: 1.23
done

Checked in on trunk.

Comment 7

[Martijn Wargers (dead)]

(In reply to comment #5)
> That it's a reflow branch regression and we should file a bug on it and fix
> it... ;)  Please cc me and dbaron on the bug.

I have filed bug 363423 for it.

Comment 8

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20061211 Minefield/3.0a1 ID:2006121108 [cairo]

verified

Comment 9

[Bill Gianopoulos [:WG9s]]

*** Bug 363333 has been marked as a duplicate of this bug. ***